[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114395: add partial RST support to cmake.xml
From: "Matthew Woehlke" <mw_triad () users ! sourceforge ! net>
Date: 2014-01-06 16:23:35
Message-ID: 20140106162335.19832.12460 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 6, 2014, 11:20 a.m., Stephen Kelly wrote:
> > .gitlog, line 32
> > <https://git.reviewboard.kde.org/r/114395/diff/3/?file=233300#file233300line32>
> >
> > You're going to rebase so that this merge commit is not needed, right?
I wasn't planning to, as it would be history destroying in this case (also was going \
to merge it as a true merge anyway, with Christoph's okay from previous comment). Do \
you feel strongly about it?
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114395/#review46919
-----------------------------------------------------------
On Jan. 6, 2014, 11:10 a.m., Matthew Woehlke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114395/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2014, 11:10 a.m.)
>
>
> Review request for Kate, Alexander Neundorf, Stephen Kelly, and Alex Turbov.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Add support for CMake 3.0 "long bracket" syntax (for string quoting and comments), \
> and for use of RST in RST bracket comments. (RST in normal comments can't be \
> trivially highlighted, as it relies on implicit removal of the leading comment \
> character, and thus is not supported.)
>
> Diffs
> -----
>
> .gitlog PRE-CREATION
> part/syntax/data/cmake.xml ccf3bb630d1451b3facb905f582a16a615b4caaa
>
> Diff: https://git.reviewboard.kde.org/r/114395/diff/
>
>
> Testing
> -------
>
> Highlighting works as expected when adding new syntax constructs to a CMake file.
>
>
> Thanks,
>
> Matthew Woehlke
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114395/">https://git.reviewboard.kde.org/r/114395/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 6th, 2014, 11:20 a.m. EST, <b>Stephen \
Kelly</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114395/diff/3/?file=233300#file233300line32" \
style="color: black; font-weight: bold; text-decoration: underline;">.gitlog</a> \
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> <span class="tb"> </span></span>part/syntax/data/cmake.xml</pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're going to \
rebase so that this merge commit is not needed, right?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I \
wasn't planning to, as it would be history destroying in this case (also was \
going to merge it as a true merge anyway, with Christoph's okay from previous \
comment). Do you feel strongly about it?</pre> <br />
<p>- Matthew</p>
<br />
<p>On January 6th, 2014, 11:10 a.m. EST, Matthew Woehlke wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate, Alexander Neundorf, Stephen Kelly, and Alex \
Turbov.</div> <div>By Matthew Woehlke.</div>
<p style="color: grey;"><i>Updated Jan. 6, 2014, 11:10 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for CMake 3.0 "long bracket" syntax (for string \
quoting and comments), and for use of RST in RST bracket comments. (RST in normal \
comments can't be trivially highlighted, as it relies on implicit removal of the \
leading comment character, and thus is not supported.)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Highlighting works as expected when adding new syntax constructs to a \
CMake file.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitlog <span style="color: grey">(PRE-CREATION)</span></li>
<li>part/syntax/data/cmake.xml <span style="color: \
grey">(ccf3bb630d1451b3facb905f582a16a615b4caaa)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114395/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic