--===============1189376498474053982== Content-Type: multipart/alternative; boundary="===============1821798215606300262==" --===============1821798215606300262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114724/ ----------------------------------------------------------- (Updated Dec. 31, 2013, 1:31 p.m.) Status ------ This change has been marked as submitted. Review request for Kate. Bugs: 323693 http://bugs.kde.org/show_bug.cgi?id=323693 Repository: kate Description ------- In normal situation the KSaveFile will be saving to blank file, so no need to call truncate manualy, but in case the folder is unwritable, the KSaveFile will write directly over the file. So the patch ensures that kate always truncates the underlying file. Test is a little bit clumsy, but does the thing. Diffs ----- part/buffer/katetextbuffer.cpp 087f450 tests/katetextbuffertest.cpp ffa566f tests/katetextbuffertest.h 254a59e Diff: https://git.reviewboard.kde.org/r/114724/diff/ Testing ------- Thanks, Michal Humpula --===============1821798215606300262== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114724/

This change has been marked as submitted.


Review request for Kate.
By Michal Humpula.

Updated Dec. 31, 2013, 1:31 p.m.

Bugs: 323693
Repository: kate

Description

In normal situation the KSaveFile will be saving to blank file, so no need to call truncate manualy, but in case the folder is unwritable, the KSaveFile will write directly over the file. So the patch ensures that kate always truncates the underlying file.

Test is a little bit clumsy, but does the thing.

Diffs

  • part/buffer/katetextbuffer.cpp (087f450)
  • tests/katetextbuffertest.cpp (ffa566f)
  • tests/katetextbuffertest.h (254a59e)

View Diff

--===============1821798215606300262==-- --===============1189376498474053982== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============1189376498474053982==--