From kwrite-devel Tue Dec 31 13:17:12 2013 From: "Michal Humpula" Date: Tue, 31 Dec 2013 13:17:12 +0000 To: kwrite-devel Subject: Re: Review Request 114638: when saving emit documentUrlChanged only when really changed Message-Id: <20131231131712.1620.85172 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138849584622917 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1233387524210408965==" --===============1233387524210408965== Content-Type: multipart/alternative; boundary="===============5194187116897287997==" --===============5194187116897287997== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114638/ ----------------------------------------------------------- (Updated Dec. 31, 2013, 1:17 p.m.) Status ------ This change has been discarded. Review request for Kate. Bugs: 329183 http://bugs.kde.org/show_bug.cgi?id=329183 Repository: kate Description ------- Couldn't find any other reason, why there should be emit documentUrlChanged() in saveFile other then "saveAs" situation. So this patch moves the emit to more apropriate place. Diffs ----- part/document/katedocument.cpp fc22006 Diff: https://git.reviewboard.kde.org/r/114638/diff/ Testing ------- make test. Visually it seems that everything is updated after saving, even in the case of a new document. Thanks, Michal Humpula --===============5194187116897287997== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114638/

This change has been discarded.

Review request for Kate.

By Michal Humpula.

Updated Dec. 31, 2013, 1:17 p.m.

Bugs: 329183

Repository: kate

Description

Couldn't find any other reason, why there should be emit documentUrlChanged() in saveFile other then "saveAs" situation. So this patch moves the emit to more apropriate place.

Testing

make test. Visually it seems that everything is updated after saving, even in the case of a new document.

Diffs

part/document/katedocument.cpp (fc22006)

View Diff

--===============5194187116897287997==-- --===============1233387524210408965== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============1233387524210408965==--