[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114751: don't append newline at the end of diff input
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2013-12-31 8:05:30
Message-ID: 20131231080530.1620.57740 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114751/#review46474
-----------------------------------------------------------
I would stick with -b.
- Christoph Cullmann
On Dec. 31, 2013, 8:03 a.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114751/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2013, 8:03 a.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 324136
> http://bugs.kde.org/show_bug.cgi?id=324136
>
>
> Repository: kate
>
>
> Description
> -------
>
> Don't pipe to diff extra newline. And while at it, do a little bit of message \
> rewording, which now corespond more closely to what "-b" means.
> The question for the plenum: should kate use "-wB" instead of "-b"? That way we \
> could keep the old message text.
>
> Diffs
> -----
>
> kate/app/katemwmodonhddialog.cpp 31b80dc
> part/dialogs/katedialogs.cpp b137fd1
>
> Diff: https://git.reviewboard.kde.org/r/114751/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114751/">https://git.reviewboard.kde.org/r/114751/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would stick with \
-b.</pre> <br />
<p>- Christoph Cullmann</p>
<br />
<p>On December 31st, 2013, 8:03 a.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2013, 8:03 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=324136">324136</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Don't pipe to diff extra newline. And while at it, do a little bit \
of message rewording, which now corespond more closely to what "-b" means.
The question for the plenum: should kate use "-wB" instead of \
"-b"? That way we could keep the old message text.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katemwmodonhddialog.cpp <span style="color: grey">(31b80dc)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(b137fd1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114751/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic