[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114619: frameworks: reenable the updateColorPalette slot
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2013-12-28 14:38:06
Message-ID: 20131228143806.18782.49809 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114619/
-----------------------------------------------------------
(Updated Dec. 28, 2013, 2:38 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Repository: kate
Description
-------
This is a little bit hackish, so second opinion is welcomed (required).
Back in KDE4 there was KGlobalSettings::kdisplayPaletteChanged() signal, which was generated, when DBus \
notification from kcontrol (?) arrived. Seems that with Qt5 QPA and its implementation in frameworks, \
this is gone. The recommended way is supossedly to
* Note: If you derive from a QWidget-based class, a faster method is to
* reimplement QWidget::changeEvent() and catch QEvent::PaletteChange.
* This is the preferred way to get informed about palette updates.
which doesn't work in a case of KateGlobal, which derives from QObject. So Loooking at the Qt5 kode, the \
QPA should send QEvent::ChangePallete to application object, which resends it to all widgets and to \
itself as QEvent::ApplicationChangePallete. So the solution simple taps to the event interface and \
listens for the right event.
Diffs
-----
part/utils/kateglobal.h 610be1d
part/utils/kateglobal.cpp f13e9a7
Diff: https://git.reviewboard.kde.org/r/114619/diff/
Testing
-------
none. `kcmshell5 colors` doesn't seems to change colors of running applications (at least for me and for \
now).
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114619/">https://git.reviewboard.kde.org/r/114619/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 28, 2013, 2:38 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a little bit hackish, so second \
opinion is welcomed (required).
Back in KDE4 there was KGlobalSettings::kdisplayPaletteChanged() signal, which was generated, when DBus \
notification from kcontrol (?) arrived. Seems that with Qt5 QPA and its implementation in frameworks, \
this is gone. The recommended way is supossedly to
* Note: If you derive from a QWidget-based class, a faster method is to
* reimplement QWidget::changeEvent() and catch QEvent::PaletteChange.
* This is the preferred way to get informed about palette updates.
which doesn't work in a case of KateGlobal, which derives from QObject. So Loooking at the Qt5 kode, \
the QPA should send QEvent::ChangePallete to application object, which resends it to all widgets and to \
itself as QEvent::ApplicationChangePallete. So the solution simple taps to the event interface and \
listens for the right event.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">none. `kcmshell5 colors` doesn't seems \
to change colors of running applications (at least for me and for now).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/utils/kateglobal.h <span style="color: grey">(610be1d)</span></li>
<li>part/utils/kateglobal.cpp <span style="color: grey">(f13e9a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114619/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic