[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114619: frameworks: reenable the updateColorPalette slot
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2013-12-27 22:08:40
Message-ID: 20131227220840.27341.78258 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114619/#review46228
-----------------------------------------------------------
Ship it!
To me, the patch looks good. Atm I don't see another elegant solution to get this \
event, since the other classes that require this info are also not QWidget-based.
So it's ok to commit, but we should make sure at some point that this works. Maybe \
come back to this in 1-2 months, when then frameworks integration matures more?
part/utils/kateglobal.cpp
<https://git.reviewboard.kde.org/r/114619/#comment33007>
Maybe we should call qApp->removeEventFilter(this) in the destructor (mainly for \
consistency)?
- Dominik Haumann
On Dec. 22, 2013, 5:51 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114619/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2013, 5:51 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This is a little bit hackish, so second opinion is welcomed (required).
>
> Back in KDE4 there was KGlobalSettings::kdisplayPaletteChanged() signal, which was \
> generated, when DBus notification from kcontrol (?) arrived. Seems that with Qt5 \
> QPA and its implementation in frameworks, this is gone. The recommended way is \
> supossedly to
> * Note: If you derive from a QWidget-based class, a faster method is to
> * reimplement QWidget::changeEvent() and catch QEvent::PaletteChange.
> * This is the preferred way to get informed about palette updates.
>
> which doesn't work in a case of KateGlobal, which derives from QObject. So Loooking \
> at the Qt5 kode, the QPA should send QEvent::ChangePallete to application object, \
> which resends it to all widgets and to itself as QEvent::ApplicationChangePallete. \
> So the solution simple taps to the event interface and listens for the right event. \
>
> Diffs
> -----
>
> part/utils/kateglobal.h 610be1d
> part/utils/kateglobal.cpp f13e9a7
>
> Diff: https://git.reviewboard.kde.org/r/114619/diff/
>
>
> Testing
> -------
>
> none. `kcmshell5 colors` doesn't seems to change colors of running applications (at \
> least for me and for now).
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114619/">https://git.reviewboard.kde.org/r/114619/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To me, the patch looks \
good. Atm I don't see another elegant solution to get this event, since the other \
classes that require this info are also not QWidget-based.
So it's ok to commit, but we should make sure at some point that this works. \
Maybe come back to this in 1-2 months, when then frameworks integration matures \
more?</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/114619/diff/1/?file=226889#file226889line195" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/utils/kateglobal.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KateGlobal::KateGlobal ()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">195</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">// finally \
setup connections</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">195</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">qApp</span><span \
class="o">-></span><span class="n">installEventFilter</span><span \
class="p">(</span><span class="k">this</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe we \
should call qApp->removeEventFilter(this) in the destructor (mainly for \
consistency)?</pre> </div>
<br />
<p>- Dominik Haumann</p>
<br />
<p>On December 22nd, 2013, 5:51 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 22, 2013, 5:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a little bit hackish, so second opinion is welcomed (required).
Back in KDE4 there was KGlobalSettings::kdisplayPaletteChanged() signal, which was \
generated, when DBus notification from kcontrol (?) arrived. Seems that with Qt5 QPA \
and its implementation in frameworks, this is gone. The recommended way is supossedly \
to
* Note: If you derive from a QWidget-based class, a faster method is to
* reimplement QWidget::changeEvent() and catch QEvent::PaletteChange.
* This is the preferred way to get informed about palette updates.
which doesn't work in a case of KateGlobal, which derives from QObject. So \
Loooking at the Qt5 kode, the QPA should send QEvent::ChangePallete to application \
object, which resends it to all widgets and to itself as \
QEvent::ApplicationChangePallete. So the solution simple taps to the event interface \
and listens for the right event.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">none. `kcmshell5 colors` doesn't seems to change colors of running \
applications (at least for me and for now).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/utils/kateglobal.h <span style="color: grey">(610be1d)</span></li>
<li>part/utils/kateglobal.cpp <span style="color: grey">(f13e9a7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114619/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic