'Re: Review Request 114669: kate: set urgent flag on window activated by dbus call'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114669: kate: set urgent flag on window activated by dbus call
From:       "Christoph Cullmann" <cullmann () kde ! org>
Date:       2013-12-26 18:12:04
Message-ID: 20131226181204.4851.14029 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Dec. 26, 2013, 6:11 p.m., Christoph Cullmann wrote:
> > Ship It!

Guess its ok for both, master & frameworks.

- Christoph

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114669/#review46160
-----------------------------------------------------------

On Dec. 26, 2013, 8:20 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114669/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2013, 8:20 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Bugs: 125738 and 128193
>     http://bugs.kde.org/show_bug.cgi?id=125738
>     http://bugs.kde.org/show_bug.cgi?id=128193
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> It's deadly simple change, so the question is rather if I can push it to master then to frameworks.
> 
> For the bugreports; I think that patchs solves the most of the problem with quite a little.
> 
> 
> Diffs
> -----
> 
>   kate/app/kateappadaptor.cpp c18a50c 
> 
> Diff: https://git.reviewboard.kde.org/r/114669/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114669/">https://git.reviewboard.kde.org/r/114669/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On December 26th, 2013, 6:11 p.m. UTC, \
<b>Christoph Cullmann</b> wrote:</p>  <blockquote style="margin-left: 1em; \
border-left: 2px solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: \
pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Guess its ok for both, \
master &amp; frameworks.</pre> <br />

<p>- Christoph</p>

<br />
<p>On December 26th, 2013, 8:20 a.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 26, 2013, 8:20 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=125738">125738</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=128193">128193</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s deadly simple change, so the question is rather if I can push \
it to master then to frameworks.

For the bugreports; I think that patchs solves the most of the problem with quite a \
little.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/kateappadaptor.cpp <span style="color: grey">(c18a50c)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114669/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 