--===============0920694285797560424== Content-Type: multipart/alternative; boundary="===============8222292828460200037==" --===============8222292828460200037== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114609/ ----------------------------------------------------------- (Updated Dec. 22, 2013, 12:34 p.m.) Status ------ This change has been marked as submitted. Review request for Kate. Repository: kate Description ------- As far as I know, there is now reason for passing pointer, it only complicates the callsites as it shown in the patch. Breaking ABI change, expecting heavy objections. Diffs ----- kate/app/katemainwindow.cpp fc6a815 ktexteditor/editor.h 57a2992 kwrite/kwritemain.cpp 50dfd5e part/document/katedocument.cpp af0a014 part/utils/kateglobal.h 0d34c66 part/view/kateview.cpp 80d1fb4 Diff: https://git.reviewboard.kde.org/r/114609/diff/ Testing ------- Thanks, Michal Humpula --===============8222292828460200037== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114609/

This change has been marked as submitted.

Review request for Kate.
By Michal Humpula.

Updated Dec. 22, 2013, 12:34 p.m.

Repository: kate

Description 

As far as I know, there is now reason for passing pointer, it only complicates the callsites as it shown in the patch.

Breaking ABI change, expecting heavy objections.

Diffs

  • kate/app/katemainwindow.cpp (fc6a815)
  • ktexteditor/editor.h (57a2992)
  • kwrite/kwritemain.cpp (50dfd5e)
  • part/document/katedocument.cpp (af0a014)
  • part/utils/kateglobal.h (0d34c66)
  • part/view/kateview.cpp (80d1fb4)

View Diff
--===============8222292828460200037==-- --===============0920694285797560424== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============0920694285797560424==--