'Re: Review Request 114609: frameworks: change KTextEditor::aboutData() declaration'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114609: frameworks: change KTextEditor::aboutData() declaration
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2013-12-22 11:51:01
Message-ID: 20131222115101.4579.78514 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114609/#review46034
-----------------------------------------------------------

Ship it!

I don't see an issue here. I'd say commit, and if Christoph has objections we revert \
;)

- Dominik Haumann

On Dec. 22, 2013, 11:39 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114609/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2013, 11:39 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> As far as I know, there is now reason for passing pointer, it only complicates the \
> callsites as it shown in the patch. 
> Breaking ABI change, expecting heavy objections.
> 
> 
> Diffs
> -----
> 
> kate/app/katemainwindow.cpp fc6a815 
> ktexteditor/editor.h 57a2992 
> kwrite/kwritemain.cpp 50dfd5e 
> part/document/katedocument.cpp af0a014 
> part/utils/kateglobal.h 0d34c66 
> part/view/kateview.cpp 80d1fb4 
> 
> Diff: https://git.reviewboard.kde.org/r/114609/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114609/">https://git.reviewboard.kde.org/r/114609/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t see an issue \
here. I&#39;d say commit, and if Christoph has objections we revert ;)</pre>  <br />

<p>- Dominik Haumann</p>

<br />
<p>On December 22nd, 2013, 11:39 a.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 22, 2013, 11:39 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As far as I know, there is now reason for passing pointer, it only \
complicates the callsites as it shown in the patch.

Breaking ABI change, expecting heavy objections.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/katemainwindow.cpp <span style="color: grey">(fc6a815)</span></li>

 <li>ktexteditor/editor.h <span style="color: grey">(57a2992)</span></li>

 <li>kwrite/kwritemain.cpp <span style="color: grey">(50dfd5e)</span></li>

 <li>part/document/katedocument.cpp <span style="color: grey">(af0a014)</span></li>

 <li>part/utils/kateglobal.h <span style="color: grey">(0d34c66)</span></li>

 <li>part/view/kateview.cpp <span style="color: grey">(80d1fb4)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114609/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 