'Re: Review Request 114551: frameworks: port from KIO::NetAccess'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114551: frameworks: port from KIO::NetAccess
From:       "Commit Hook" <null () kde ! org>
Date:       2013-12-21 22:08:39
Message-ID: 20131221220839.26597.56334 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114551/#review46019
-----------------------------------------------------------

This review has been submitted with commit 114068384207e8bb03c574f93ca5f4da0a28ebfb \
by Michal Humpula to branch frameworks.

- Commit Hook

On Dec. 19, 2013, 10:54 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114551/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2013, 10:54 p.m.)
> 
> 
> Review request for Kate and David Faure.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> KIO::NetAccess made it to kde4support, so this is the patch to port from it.
> 
> This is my first touch with KIO, so need someone to recheck if it makes sense. Apps \
> are running ok it seems:) 
> 
> Diffs
> -----
> 
> kate/app/katesession.cpp 17d8741 
> kwrite/kwritemain.cpp fc14fda 
> part/dialogs/katedialogs.cpp c536d3d 
> part/document/katedocument.cpp 286c061 
> 
> Diff: http://git.reviewboard.kde.org/r/114551/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114551/">http://git.reviewboard.kde.org/r/114551/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 114068384207e8bb03c574f93ca5f4da0a28ebfb by Michal Humpula to \
branch frameworks.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On December 19th, 2013, 10:54 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and David Faure.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 19, 2013, 10:54 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KIO::NetAccess made it to kde4support, so this is the patch to port from \
it.

This is my first touch with KIO, so need someone to recheck if it makes sense. Apps \
are running ok it seems:)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/katesession.cpp <span style="color: grey">(17d8741)</span></li>

 <li>kwrite/kwritemain.cpp <span style="color: grey">(fc14fda)</span></li>

 <li>part/dialogs/katedialogs.cpp <span style="color: grey">(c536d3d)</span></li>

 <li>part/document/katedocument.cpp <span style="color: grey">(286c061)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114551/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 