[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 112187: Simplify KateDocManager::openUrl
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2013-12-21 20:27:21
Message-ID: 20131221202721.6944.14488 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112187/
-----------------------------------------------------------
(Updated Dec. 21, 2013, 8:27 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate and Christoph Cullmann.
Bugs: 319354
http://bugs.kde.org/show_bug.cgi?id=319354
Repository: kate
Description
-------
Currently, KateDocManager::openUrl() reuses the untitled unmodified document to load \
a new file. This, however, leads to i) code duplication and ii) two different code \
paths for opening documents. In case the existing untitled document is replaced, a \
new view is not created, and therefore View::readSessionConfig() is not called.
This patch simplifies opening a new url by simply always creating a new Document. If \
applicable, the untitled unmodified document is then deleted afterwards.
This has the slight disadvantage of flickering, but flickering also exists for each \
additional file you open anyway, so this problem is not really new.
The isTempFile option is now moved behind loading the file, it was at a different \
location before. Hope this is still correct.
Diffs
-----
kate/app/katedocmanager.cpp f13876c
kate/app/kateviewmanager.cpp 2dbd1f9
Diff: http://git.reviewboard.kde.org/r/112187/diff/
Testing
-------
Opening a file now always restores the cursor position.
Thanks,
Dominik Haumann
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112187/">http://git.reviewboard.kde.org/r/112187/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Christoph Cullmann.</div>
<div>By Dominik Haumann.</div>
<p style="color: grey;"><i>Updated Dec. 21, 2013, 8:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319354">319354</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, KateDocManager::openUrl() reuses the untitled unmodified \
document to load a new file. This, however, leads to i) code duplication and ii) two \
different code paths for opening documents. In case the existing untitled document is \
replaced, a new view is not created, and therefore View::readSessionConfig() is not \
called.
This patch simplifies opening a new url by simply always creating a new Document. If \
applicable, the untitled unmodified document is then deleted afterwards.
This has the slight disadvantage of flickering, but flickering also exists for each \
additional file you open anyway, so this problem is not really new.
The isTempFile option is now moved behind loading the file, it was at a different \
location before. Hope this is still correct.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Opening a file now always restores the cursor position.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katedocmanager.cpp <span style="color: grey">(f13876c)</span></li>
<li>kate/app/kateviewmanager.cpp <span style="color: grey">(2dbd1f9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112187/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic