'Re: Review Request 114586: Attempt to fix crash in KateDocument::defStyleNum'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114586: Attempt to fix crash in KateDocument::defStyleNum
From:       "Commit Hook" <null () kde ! org>
Date:       2013-12-21 17:00:18
Message-ID: 20131221170018.25811.33969 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114586/#review46005
-----------------------------------------------------------

This review has been submitted with commit d992a1905baf704d1040d2e63cce4f1d937cdf5e \
by Dominik Haumann to branch KDE/4.12.

- Commit Hook

On Dec. 21, 2013, 4:59 p.m., Dominik Haumann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114586/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2013, 4:59 p.m.)
> 
> 
> Review request for Kate, Christoph Cullmann and Michal Humpula.
> 
> 
> Bugs: 328271
> http://bugs.kde.org/show_bug.cgi?id=328271
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> KateDocument::defStyleNum sometimes crashes when called through KateScriptDocument.
> 
> This is an attempt to fix it. The only change is that we now check whether the \
> Kate::TextLine is a valid pointer. Everything else is just the same. 
> 
> Diffs
> -----
> 
> part/document/katedocument.cpp d0cf31e 
> 
> Diff: http://git.reviewboard.kde.org/r/114586/diff/
> 
> 
> Testing
> -------
> 
> None, I cannot reproduce...
> 
> 
> Thanks,
> 
> Dominik Haumann
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114586/">http://git.reviewboard.kde.org/r/114586/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d992a1905baf704d1040d2e63cce4f1d937cdf5e by Dominik Haumann to \
branch KDE/4.12.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On December 21st, 2013, 4:59 p.m. UTC, Dominik Haumann wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Christoph Cullmann and Michal Humpula.</div>
<div>By Dominik Haumann.</div>

<p style="color: grey;"><i>Updated Dec. 21, 2013, 4:59 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=328271">328271</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KateDocument::defStyleNum sometimes crashes when called through \
KateScriptDocument.

This is an attempt to fix it. The only change is that we now check whether the \
Kate::TextLine is a valid pointer. Everything else is just the same.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None, I cannot reproduce...</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/document/katedocument.cpp <span style="color: grey">(d0cf31e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114586/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 