[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate/frameworks] part: port away from QAbstractItemModel::reset()
From:       Milian Wolff <mail () milianw ! de>
Date:       2013-12-19 21:01:44
Message-ID: 3148416.YJPrQnVugE () minime
[Download RAW message or body]

On Thursday 19 December 2013 20:57:49 Dominik Haumann wrote:
> Hi Milian,
> 
> On Thursday 19 December 2013 20:36:44 Milian Wolff wrote:
> > On Thursday 19 December 2013 17:58:25 Michal Humpula wrote:
> > > Git commit e6374518f5a966b8badda3a5e90fb873cd7ec08e by Michal Humpula.
> > > Committed on 19/12/2013 at 17:54.
> > > Pushed by michalhumpula into branch 'frameworks'.
> > > 
> > > port away from QAbstractItemModel::reset()
> > 
> > This is potentially dangerous as it can easily lead to undesired
> > side-effects, esp. performance wise.
> > 
> > See also: https://git.reviewboard.kde.org/r/113917/
> 
> So can you be more constructive about what exactly to do here?
> Saying it's "potentially dangerous" does not help much ;)
> 
> Will this review resolve this, and when we merge master into frameworks we
> don't need Michals changes anymore?

I mean that instead of adding reset blindly to KF5, we should get the above 
mentioned review request into a usable state first.

It's not merged for a reason (namely performance impact).

Bye
-- 
Milian Wolff
mail@milianw.de
http://milianw.de
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]