[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114528: Sets the default alternate shortcut for "Quick open" action
From:       Kåre_Särs <kare.sars () iki ! fi>
Date:       2013-12-19 9:49:55
Message-ID: 5486484.F8UWOQxrEh () sars-laptop64
[Download RAW message or body]

On Thursday 19 December 2013 10:17:45 Dominik Haumann wrote:
> Hi K=E5re,
> =

> On Thursday 19 December 2013 10:29:29 K=E5re S=E4rs wrote:
> > Hi Gregor,
> > =

> > It seems a bit strange to post a review and then give it a "Ship it" yo=
ur
> > self and then commit it all within 5 minutes.
> =

> It was mostly a test: we met yesterday and went through all the workflow =
of
> getting, building, installing kde frameworks and Kate, and how to use the
> tools like reviewboard. So while it apparently wasn't obvious for others,
> this review request was not really about getting a review :-p

OK, then I have no objection ;)

/K=E5re

> =

> > Assigning an extra alternative shortcut to an action is also something
> > that
> > should be discussed on the mailing-list IMHO. I think we should keep the
> > assigned shortcuts to a minimum as it becomes really hard to find new k=
ey
> > combinations that do not conflict with other actions.
> =

> In principle I agree. But this is on Kate Application level, therefore it=
's
> not a problem with other applications like KDevelop or so. And in fact,
> having Ctrl+Tab switch the active document makes a whole lot of more sense
> compared to having Ctrl+Tab inserting a <Tab> character, as it was before.
> =

> But yes, we could have written all this in the review-request, or in the =
git
> log message -- next time! ;)
> =

> Best,
> Dominik
> =

> >  /K=E5re
> > =

> > On Wednesday 18 December 2013 16:39:31 Gregor Mi wrote:
> > =

> > =

> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/114528/
> > =

> > =

> > This change has been marked as submitted.
> > =

> > =

> > Review request for Kate and Dominik Haumann.
> > By Gregor Mi.
> > Updated Dec. 18, 2013, 4:39 p.m.
> > Bugs: 324348
> > Repository: kate
> > Description
> > Sets the default alternate shortcut for "Quick open" action
> > =

> > Testing
> > ok
> > =

> > Diffs
> > kate/app/katemainwindow.cpp (b4f51f4)
> > View Diff

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]