'Re: Review Request 114462: KF5 Porting, Exposing KTextEditor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114462: KF5 Porting, Exposing KTextEditor
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2013-12-16 23:46:18
Message-ID: 20131216234618.9168.68606 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114462/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 11:46 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate.

Repository: kate

Description
-------

Export KTextEditor so that it can be imported by other projects (such as KDevelop \
:D). Do some KDE4Support porting, I wanted to port templateinterface.cpp but it \
wasn't a trivial port (KCalendarSystem doesn't really have a proper replacement \
AFAIK), so I decided to ask you guys if you think it's still needed and all.

Diffs
-----

  CMakeLists.txt ef622c8 
  addons/kate/backtracebrowser/katebacktracebrowser.cpp 47dabc0 
  ktexteditor/CMakeLists.txt 59ca129 
  ktexteditor/cursor.h 87df311 
  ktexteditor/factory.h d018726 
  ktexteditor/ktexteditor.cpp 95a5dac 
  ktexteditor/templateinterface.cpp 82868b6 
  kwrite/kwriteapp.cpp 194b3d5 
  part/completion/expandingtree/expandingwidgetmodel.cpp da4a440 

Diff: http://git.reviewboard.kde.org/r/114462/diff/

Testing
-------

Thanks,

Aleix Pol Gonzalez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114462/">http://git.reviewboard.kde.org/r/114462/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2013, 11:46 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Export KTextEditor so that it can be imported by other projects (such as \
KDevelop :D). Do some KDE4Support porting, I wanted to port templateinterface.cpp but \
it wasn&#39;t a trivial port (KCalendarSystem doesn&#39;t really have a proper \
replacement AFAIK), so I decided to ask you guys if you think it&#39;s still needed \
and all.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(ef622c8)</span></li>

 <li>addons/kate/backtracebrowser/katebacktracebrowser.cpp <span style="color: \
grey">(47dabc0)</span></li>

 <li>ktexteditor/CMakeLists.txt <span style="color: grey">(59ca129)</span></li>

 <li>ktexteditor/cursor.h <span style="color: grey">(87df311)</span></li>

 <li>ktexteditor/factory.h <span style="color: grey">(d018726)</span></li>

 <li>ktexteditor/ktexteditor.cpp <span style="color: grey">(95a5dac)</span></li>

 <li>ktexteditor/templateinterface.cpp <span style="color: \
grey">(82868b6)</span></li>

 <li>kwrite/kwriteapp.cpp <span style="color: grey">(194b3d5)</span></li>

 <li>part/completion/expandingtree/expandingwidgetmodel.cpp <span style="color: \
grey">(da4a440)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114462/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 