[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114491: frameworks: kDebug to qCDebug (part)
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2013-12-16 17:31:53
Message-ID: 20131216173153.23869.65044 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114491/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 5:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate.
Repository: kate
Description
-------
Dear reviewers, I'm so sorry:) This patch is 80% sed substitution.
== highlights ==
* added part/katepartdebug.h file
* debug filter initialization in part plugin constructor
* removed specialized logging in part/spellcheck/ontheflycheck.cpp
== notes ==
* there are lots of commented out kDebug statements, should they be deleted instead?
* you can find even few places like this: kDebug(13070) << "Heere!";
* should there be some #ifdef DEBUG optimalization? (There seems to be few places \
like this with macros like FAST_DEBUG_ENABLE, EDIT_DEBUG, ...)
Diffs
-----
part/CMakeLists.txt 2a9631c
part/buffer/katetextbuffer.cpp 4093257
part/completion/expandingtree/expandingdelegate.cpp 8188885
part/completion/expandingtree/expandingtree.cpp 83c1436
part/completion/expandingtree/expandingwidgetmodel.cpp da4a440
part/completion/kateargumenthintmodel.cpp 118cdf8
part/completion/kateargumenthinttree.cpp 997f9d2
part/completion/katecompletiondelegate.cpp f7a29e4
part/completion/katecompletionmodel.cpp ed26e9a
part/completion/katecompletiontree.cpp 237e8e0
part/completion/katecompletionwidget.cpp f1a14fe
part/completion/katewordcompletion.h 623b560
part/completion/katewordcompletion.cpp b1b1d1b
part/dialogs/katedialogs.cpp fea3660
part/document/katebuffer.cpp f34936c
part/document/katedocument.cpp 124b29e
part/katepartdebug.h PRE-CREATION
part/mode/katemodeconfigpage.cpp aa46d88
part/mode/katemodemanager.cpp 33c700e
part/mode/katemodemenu.cpp 7ba0bc7
part/render/katelayoutcache.cpp 367fca7
part/render/katelinelayout.cpp d3631a0
part/render/katerenderer.cpp c5c2628
part/render/katetextlayout.cpp 86c02ca
part/schema/katecolortreewidget.cpp ccafa2b
part/schema/kateschema.cpp af76e82
part/schema/kateschemaconfig.cpp 94e485e
part/script/katecommandlinescript.cpp 8611844
part/script/kateindentscript.cpp 91c6314
part/script/katescript.cpp 8f649e9
part/script/katescriptaction.cpp cbcf36b
part/script/katescriptdocument.cpp 932eb59
part/script/katescripthelpers.cpp cb2e6da
part/script/katescriptmanager.h a16ab15
part/script/katescriptmanager.cpp 19df8d8
part/search/kateplaintextsearch.cpp e1d24ed
part/search/kateregexpsearch.cpp 0f4d42c
part/search/katesearchbar.cpp f4586df
part/snippet/snippetrepository.cpp 285d5f7
part/snippet/snippetstore.cpp 66fafec
part/snippet/snippetview.cpp 82348d5
part/spellcheck/ontheflycheck.h 991f7d0
part/spellcheck/ontheflycheck.cpp 7ad9b23
part/spellcheck/prefixstore.cpp 3252890
part/spellcheck/spellingmenu.cpp d27fc6b
part/swapfile/kateswapdiffcreator.cpp 7f14de6
part/swapfile/kateswapfile.cpp f345804
part/syntax/katehighlight.cpp 1bdfd4e
part/syntax/katehighlighthelpers.cpp f5c1823
part/syntax/katehighlightmenu.cpp 91e404c
part/syntax/katesyntaxdocument.cpp 06fc34c
part/syntax/katesyntaxmanager.cpp e165f85
part/undo/kateundomanager.cpp bc4c1fc
part/utils/kateautoindent.cpp f7d7394
part/utils/katecmd.cpp a5ce499
part/utils/katecmds.cpp e7da9e8
part/utils/kateconfig.cpp 6ff3526
part/utils/katefactory.cpp 5a84328
part/utils/kateglobal.cpp df30798
part/utils/katepartpluginmanager.cpp 131d244
part/utils/kateprinter.cpp 36e4b0d
part/utils/katetemplatehandler.cpp b823094
part/view/katemessagewidget.cpp c6fbcb9
part/view/kateview.h ed53a4b
part/view/kateview.cpp ef72fdf
part/view/kateviewhelpers.cpp b0de78b
part/view/kateviewinternal.cpp 668b967
part/vimode/kateviemulatedcommandbar.cpp 3944bf1
part/vimode/kateviglobal.cpp eab39c2
part/vimode/kateviinputmodemanager.cpp 311a027
part/vimode/kateviinsertmode.cpp de09cb1
part/vimode/katevikeymapper.cpp 2de54a4
part/vimode/katevimodebase.cpp 3bae946
part/vimode/katevinormalmode.cpp b828c20
part/vimode/katevirange.h 28052e2
Diff: http://git.reviewboard.kde.org/r/114491/diff/
Testing
-------
compile and run.
Thanks,
Michal Humpula
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114491/">http://git.reviewboard.kde.org/r/114491/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 16, 2013, 5:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dear reviewers, I'm so sorry:) This patch is 80% sed substitution.
== highlights ==
* added part/katepartdebug.h file
* debug filter initialization in part plugin constructor
* removed specialized logging in part/spellcheck/ontheflycheck.cpp
== notes ==
* there are lots of commented out kDebug statements, should they be deleted instead?
* you can find even few places like this: kDebug(13070) << "Heere!";
* should there be some #ifdef DEBUG optimalization? (There seems to be few places \
like this with macros like FAST_DEBUG_ENABLE, EDIT_DEBUG, ...)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compile and run.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/CMakeLists.txt <span style="color: grey">(2a9631c)</span></li>
<li>part/buffer/katetextbuffer.cpp <span style="color: grey">(4093257)</span></li>
<li>part/completion/expandingtree/expandingdelegate.cpp <span style="color: \
grey">(8188885)</span></li>
<li>part/completion/expandingtree/expandingtree.cpp <span style="color: \
grey">(83c1436)</span></li>
<li>part/completion/expandingtree/expandingwidgetmodel.cpp <span style="color: \
grey">(da4a440)</span></li>
<li>part/completion/kateargumenthintmodel.cpp <span style="color: \
grey">(118cdf8)</span></li>
<li>part/completion/kateargumenthinttree.cpp <span style="color: \
grey">(997f9d2)</span></li>
<li>part/completion/katecompletiondelegate.cpp <span style="color: \
grey">(f7a29e4)</span></li>
<li>part/completion/katecompletionmodel.cpp <span style="color: \
grey">(ed26e9a)</span></li>
<li>part/completion/katecompletiontree.cpp <span style="color: \
grey">(237e8e0)</span></li>
<li>part/completion/katecompletionwidget.cpp <span style="color: \
grey">(f1a14fe)</span></li>
<li>part/completion/katewordcompletion.h <span style="color: \
grey">(623b560)</span></li>
<li>part/completion/katewordcompletion.cpp <span style="color: \
grey">(b1b1d1b)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(fea3660)</span></li>
<li>part/document/katebuffer.cpp <span style="color: grey">(f34936c)</span></li>
<li>part/document/katedocument.cpp <span style="color: grey">(124b29e)</span></li>
<li>part/katepartdebug.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>part/mode/katemodeconfigpage.cpp <span style="color: grey">(aa46d88)</span></li>
<li>part/mode/katemodemanager.cpp <span style="color: grey">(33c700e)</span></li>
<li>part/mode/katemodemenu.cpp <span style="color: grey">(7ba0bc7)</span></li>
<li>part/render/katelayoutcache.cpp <span style="color: grey">(367fca7)</span></li>
<li>part/render/katelinelayout.cpp <span style="color: grey">(d3631a0)</span></li>
<li>part/render/katerenderer.cpp <span style="color: grey">(c5c2628)</span></li>
<li>part/render/katetextlayout.cpp <span style="color: grey">(86c02ca)</span></li>
<li>part/schema/katecolortreewidget.cpp <span style="color: \
grey">(ccafa2b)</span></li>
<li>part/schema/kateschema.cpp <span style="color: grey">(af76e82)</span></li>
<li>part/schema/kateschemaconfig.cpp <span style="color: grey">(94e485e)</span></li>
<li>part/script/katecommandlinescript.cpp <span style="color: \
grey">(8611844)</span></li>
<li>part/script/kateindentscript.cpp <span style="color: grey">(91c6314)</span></li>
<li>part/script/katescript.cpp <span style="color: grey">(8f649e9)</span></li>
<li>part/script/katescriptaction.cpp <span style="color: grey">(cbcf36b)</span></li>
<li>part/script/katescriptdocument.cpp <span style="color: \
grey">(932eb59)</span></li>
<li>part/script/katescripthelpers.cpp <span style="color: \
grey">(cb2e6da)</span></li>
<li>part/script/katescriptmanager.h <span style="color: grey">(a16ab15)</span></li>
<li>part/script/katescriptmanager.cpp <span style="color: \
grey">(19df8d8)</span></li>
<li>part/search/kateplaintextsearch.cpp <span style="color: \
grey">(e1d24ed)</span></li>
<li>part/search/kateregexpsearch.cpp <span style="color: grey">(0f4d42c)</span></li>
<li>part/search/katesearchbar.cpp <span style="color: grey">(f4586df)</span></li>
<li>part/snippet/snippetrepository.cpp <span style="color: \
grey">(285d5f7)</span></li>
<li>part/snippet/snippetstore.cpp <span style="color: grey">(66fafec)</span></li>
<li>part/snippet/snippetview.cpp <span style="color: grey">(82348d5)</span></li>
<li>part/spellcheck/ontheflycheck.h <span style="color: grey">(991f7d0)</span></li>
<li>part/spellcheck/ontheflycheck.cpp <span style="color: \
grey">(7ad9b23)</span></li>
<li>part/spellcheck/prefixstore.cpp <span style="color: grey">(3252890)</span></li>
<li>part/spellcheck/spellingmenu.cpp <span style="color: grey">(d27fc6b)</span></li>
<li>part/swapfile/kateswapdiffcreator.cpp <span style="color: \
grey">(7f14de6)</span></li>
<li>part/swapfile/kateswapfile.cpp <span style="color: grey">(f345804)</span></li>
<li>part/syntax/katehighlight.cpp <span style="color: grey">(1bdfd4e)</span></li>
<li>part/syntax/katehighlighthelpers.cpp <span style="color: \
grey">(f5c1823)</span></li>
<li>part/syntax/katehighlightmenu.cpp <span style="color: \
grey">(91e404c)</span></li>
<li>part/syntax/katesyntaxdocument.cpp <span style="color: \
grey">(06fc34c)</span></li>
<li>part/syntax/katesyntaxmanager.cpp <span style="color: \
grey">(e165f85)</span></li>
<li>part/undo/kateundomanager.cpp <span style="color: grey">(bc4c1fc)</span></li>
<li>part/utils/kateautoindent.cpp <span style="color: grey">(f7d7394)</span></li>
<li>part/utils/katecmd.cpp <span style="color: grey">(a5ce499)</span></li>
<li>part/utils/katecmds.cpp <span style="color: grey">(e7da9e8)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(6ff3526)</span></li>
<li>part/utils/katefactory.cpp <span style="color: grey">(5a84328)</span></li>
<li>part/utils/kateglobal.cpp <span style="color: grey">(df30798)</span></li>
<li>part/utils/katepartpluginmanager.cpp <span style="color: \
grey">(131d244)</span></li>
<li>part/utils/kateprinter.cpp <span style="color: grey">(36e4b0d)</span></li>
<li>part/utils/katetemplatehandler.cpp <span style="color: \
grey">(b823094)</span></li>
<li>part/view/katemessagewidget.cpp <span style="color: grey">(c6fbcb9)</span></li>
<li>part/view/kateview.h <span style="color: grey">(ed53a4b)</span></li>
<li>part/view/kateview.cpp <span style="color: grey">(ef72fdf)</span></li>
<li>part/view/kateviewhelpers.cpp <span style="color: grey">(b0de78b)</span></li>
<li>part/view/kateviewinternal.cpp <span style="color: grey">(668b967)</span></li>
<li>part/vimode/kateviemulatedcommandbar.cpp <span style="color: \
grey">(3944bf1)</span></li>
<li>part/vimode/kateviglobal.cpp <span style="color: grey">(eab39c2)</span></li>
<li>part/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(311a027)</span></li>
<li>part/vimode/kateviinsertmode.cpp <span style="color: grey">(de09cb1)</span></li>
<li>part/vimode/katevikeymapper.cpp <span style="color: grey">(2de54a4)</span></li>
<li>part/vimode/katevimodebase.cpp <span style="color: grey">(3bae946)</span></li>
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(b828c20)</span></li>
<li>part/vimode/katevirange.h <span style="color: grey">(28052e2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114491/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic