'Re: Review Request 114486: frameworks: convert kDebug to qCdebug (filetree)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114486: frameworks: convert kDebug to qCdebug (filetree)
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-16 17:13:08
Message-ID: 20131216171308.20902.45674 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114486/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 5:13 p.m.)

Status
------

This change has been marked as submitted.

Review request for Kate and Mark Gaiser.

Repository: kate

Description
-------

For simplier review, I will post this in several patches, component by component. The \
filetree was deadly easy, because the infrastructure was mostly there already. Not \
sure about the #ifndef macro, though.

Tried to grep the kdelibs and kde-runtime, but seems that almost no one is using it \
right now. Although example at http://qt-project.org/doc/qt-5/qloggingcategory.html \
has domain like keys, the current users in kdelibs are setting the previously used \
non domain values.

I've used these documents:

http://community.kde.org/Frameworks/Porting_To_qCDebug
http://techbase.kde.org/Development/Tutorials/Debugging/Using_Error_Messages#Qt_5_.2F_KDE_Frameworks_5

Diffs
-----

  kate/filetree/katefiletree.cpp 6d025f4 
  kate/filetree/katefiletreeconfigpage.cpp 317627b 
  kate/filetree/katefiletreedebug.h 00924cc 
  kate/filetree/katefiletreemodel.cpp 8d8cf07 
  kate/filetree/katefiletreeplugin.cpp ebf7c2f 
  kate/filetree/katefiletreepluginsettings.cpp bb61793 
  kate/filetree/katefiletreeproxymodel.cpp 8e28bd7 

Diff: http://git.reviewboard.kde.org/r/114486/diff/

Testing
-------

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114486/">http://git.reviewboard.kde.org/r/114486/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate and Mark Gaiser.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2013, 5:13 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For simplier review, I will post this in several patches, component by \
component. The filetree was deadly easy, because the infrastructure was mostly there \
already. Not sure about the #ifndef macro, though.

Tried to grep the kdelibs and kde-runtime, but seems that almost no one is using it \
right now. Although example at http://qt-project.org/doc/qt-5/qloggingcategory.html \
has domain like keys, the current users in kdelibs are setting the previously used \
non domain values.

I&#39;ve used these documents:

http://community.kde.org/Frameworks/Porting_To_qCDebug
http://techbase.kde.org/Development/Tutorials/Debugging/Using_Error_Messages#Qt_5_.2F_KDE_Frameworks_5</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/filetree/katefiletree.cpp <span style="color: grey">(6d025f4)</span></li>

 <li>kate/filetree/katefiletreeconfigpage.cpp <span style="color: \
grey">(317627b)</span></li>

 <li>kate/filetree/katefiletreedebug.h <span style="color: \
grey">(00924cc)</span></li>

 <li>kate/filetree/katefiletreemodel.cpp <span style="color: \
grey">(8d8cf07)</span></li>

 <li>kate/filetree/katefiletreeplugin.cpp <span style="color: \
grey">(ebf7c2f)</span></li>

 <li>kate/filetree/katefiletreepluginsettings.cpp <span style="color: \
grey">(bb61793)</span></li>

 <li>kate/filetree/katefiletreeproxymodel.cpp <span style="color: \
grey">(8e28bd7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114486/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 