'Re: Review Request 114497: frameworks: migrate from KIcon to QIcon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114497: frameworks: migrate from KIcon to QIcon
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-16 15:51:03
Message-ID: 20131216155103.7044.25281 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114497/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 3:51 p.m.)

Status
------

This change has been discarded.

Review request for Kate.

Repository: kate

Description
-------

Mostly simple rename. There are two cases, where the overlay is used. For those the \
KIconUtils::addOverlay is used instead, see https://git.reviewboard.kde.org/r/112079/

Diffs
-----

  part/view/kateview.cpp ef72fdf 
  part/view/kateviewhelpers.cpp b0de78b 
  part/variableeditor/variablelineedit.cpp 8f19a19 
  part/utils/kateglobal.cpp df30798 
  part/utils/kateprinter.cpp 36e4b0d 
  part/utils/katebookmarks.cpp be8e296 
  part/utils/kateglobal.h 02f18db 
  part/spellcheck/spellcheckdialog.cpp 624b9da 
  part/swapfile/kateswapfile.cpp f345804 
  part/snippet/snippetview.cpp 82348d5 
  part/snippet/snippet.cpp d232f7a 
  part/snippet/snippetrepository.cpp 285d5f7 
  part/snippet/editsnippet.cpp e22232a 
  part/script/katescriptconsole.cpp ab69cf2 
  part/search/katesearchbar.cpp f4586df 
  part/schema/katestyletreewidget.cpp c3679a6 
  part/script/katescriptaction.cpp cbcf36b 
  part/schema/katecolortreewidget.cpp ccafa2b 
  part/document/katedocument.cpp 55639e9 
  part/mode/katemodeconfigpage.cpp aa46d88 
  part/completion/katewordcompletion.cpp b1b1d1b 
  part/dialogs/katedialogs.cpp fea3660 
  part/completion/katecompletionwidget.cpp f1a14fe 
  kwrite/kwritemain.cpp 2203fb7 
  part/completion/katecompletionconfig.cpp 16d6bfe 
  ktexteditor/editor.h 7368dd9 
  kate/filetree/katefiletreeplugin.cpp ebf7c2f 
  kate/interfaces/kate/pluginconfigpageinterface.h db5a3d7 
  kate/filetree/katefiletreeplugin.h 80e2a58 
  kate/filetree/katefiletree.cpp 3a03758 
  kate/filetree/katefiletreemodel.cpp 6bd81f3 
  kate/filetree/katefiletree.h 89e8908 
  kate/app/kateviewspace.cpp a280083 
  kate/app/katemdi.cpp 6c44442 
  kate/app/kateviewmanager.cpp 2e60274 
  kate/app/kateconfigdialog.cpp e340edb 
  kate/app/katemainwindow.cpp 84b5faf 

Diff: http://git.reviewboard.kde.org/r/114497/diff/

Testing
-------

compile and run.

Thanks,

Michal Humpula

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114497/">http://git.reviewboard.kde.org/r/114497/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 16, 2013, 3:51 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mostly simple rename. There are two cases, where the overlay is used. \
For those the KIconUtils::addOverlay is used instead, see \
https://git.reviewboard.kde.org/r/112079/</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compile and run.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/view/kateview.cpp <span style="color: grey">(ef72fdf)</span></li>

 <li>part/view/kateviewhelpers.cpp <span style="color: grey">(b0de78b)</span></li>

 <li>part/variableeditor/variablelineedit.cpp <span style="color: \
grey">(8f19a19)</span></li>

 <li>part/utils/kateglobal.cpp <span style="color: grey">(df30798)</span></li>

 <li>part/utils/kateprinter.cpp <span style="color: grey">(36e4b0d)</span></li>

 <li>part/utils/katebookmarks.cpp <span style="color: grey">(be8e296)</span></li>

 <li>part/utils/kateglobal.h <span style="color: grey">(02f18db)</span></li>

 <li>part/spellcheck/spellcheckdialog.cpp <span style="color: \
grey">(624b9da)</span></li>

 <li>part/swapfile/kateswapfile.cpp <span style="color: grey">(f345804)</span></li>

 <li>part/snippet/snippetview.cpp <span style="color: grey">(82348d5)</span></li>

 <li>part/snippet/snippet.cpp <span style="color: grey">(d232f7a)</span></li>

 <li>part/snippet/snippetrepository.cpp <span style="color: \
grey">(285d5f7)</span></li>

 <li>part/snippet/editsnippet.cpp <span style="color: grey">(e22232a)</span></li>

 <li>part/script/katescriptconsole.cpp <span style="color: \
grey">(ab69cf2)</span></li>

 <li>part/search/katesearchbar.cpp <span style="color: grey">(f4586df)</span></li>

 <li>part/schema/katestyletreewidget.cpp <span style="color: \
grey">(c3679a6)</span></li>

 <li>part/script/katescriptaction.cpp <span style="color: grey">(cbcf36b)</span></li>

 <li>part/schema/katecolortreewidget.cpp <span style="color: \
grey">(ccafa2b)</span></li>

 <li>part/document/katedocument.cpp <span style="color: grey">(55639e9)</span></li>

 <li>part/mode/katemodeconfigpage.cpp <span style="color: grey">(aa46d88)</span></li>

 <li>part/completion/katewordcompletion.cpp <span style="color: \
grey">(b1b1d1b)</span></li>

 <li>part/dialogs/katedialogs.cpp <span style="color: grey">(fea3660)</span></li>

 <li>part/completion/katecompletionwidget.cpp <span style="color: \
grey">(f1a14fe)</span></li>

 <li>kwrite/kwritemain.cpp <span style="color: grey">(2203fb7)</span></li>

 <li>part/completion/katecompletionconfig.cpp <span style="color: \
grey">(16d6bfe)</span></li>

 <li>ktexteditor/editor.h <span style="color: grey">(7368dd9)</span></li>

 <li>kate/filetree/katefiletreeplugin.cpp <span style="color: \
grey">(ebf7c2f)</span></li>

 <li>kate/interfaces/kate/pluginconfigpageinterface.h <span style="color: \
grey">(db5a3d7)</span></li>

 <li>kate/filetree/katefiletreeplugin.h <span style="color: \
grey">(80e2a58)</span></li>

 <li>kate/filetree/katefiletree.cpp <span style="color: grey">(3a03758)</span></li>

 <li>kate/filetree/katefiletreemodel.cpp <span style="color: \
grey">(6bd81f3)</span></li>

 <li>kate/filetree/katefiletree.h <span style="color: grey">(89e8908)</span></li>

 <li>kate/app/kateviewspace.cpp <span style="color: grey">(a280083)</span></li>

 <li>kate/app/katemdi.cpp <span style="color: grey">(6c44442)</span></li>

 <li>kate/app/kateviewmanager.cpp <span style="color: grey">(2e60274)</span></li>

 <li>kate/app/kateconfigdialog.cpp <span style="color: grey">(e340edb)</span></li>

 <li>kate/app/katemainwindow.cpp <span style="color: grey">(84b5faf)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114497/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 