[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114485: frameworks: migrate from KUrl to QUrl
From:       "Michal Humpula" <michal.humpula () seznam ! cz>
Date:       2013-12-16 12:13:35
Message-ID: 20131216121335.4882.13498 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114485/
-----------------------------------------------------------

(Updated Dec. 16, 2013, 12:13 p.m.)


Status
------

This change has been marked as submitted.


Review request for Kate.


Repository: kate


Description
-------

It's mostly straighforward, but few places are guestimates.

btw, is there any transitional documentation? I tried to find info in KUrl, but there \
is not any:( Generaly lots of stuff is marked deprecated, but I can't find any place \
hinting the correct substitution. Any hint?:)


Diffs
-----

  kate/app/kateapp.h 9775189 
  kate/app/kateapp.cpp 7d26c62 
  kate/app/kateappcommands.cpp e5de9f7 
  kate/app/katedocmanager.h 1359a20 
  kate/app/katedocmanager.cpp 387e759 
  kate/app/katemainwindow.h c81c14c 
  kate/app/katemainwindow.cpp 8a569c8 
  kate/app/katemwmodonhddialog.cpp bacfb03 
  kate/app/katequickopen.cpp e4c37d9 
  kate/app/katesavemodifieddialog.cpp 4a7e47e 
  kate/app/katesession.cpp 004dcbc 
  kate/app/kateviewmanager.h 7a27357 
  kate/app/kateviewmanager.cpp 429d064 
  kate/app/kateviewspace.cpp dc43812 
  kate/filetree/katefiletree.h 1c4362c 
  kate/filetree/katefiletree.cpp 6d025f4 
  kate/filetree/katefiletreemodel.cpp 8d8cf07 
  kate/interfaces/kate/application.h e65e474 
  kate/interfaces/kate/documentmanager.h 119a8f5 
  kate/interfaces/kate/documentmanager.cpp 68a76c0 
  kate/interfaces/kate/mainwindow.h 0c4be6b 
  kate/interfaces/kate/mainwindow.cpp c469627 
  kate/interfaces/kate/plugin.h df64d2f 
  kate/interfaces/kate/pluginmanager.h 680516d 
  part/utils/katecmds.cpp e7da9e8 

Diff: http://git.reviewboard.kde.org/r/114485/diff/


Testing
-------

manualy openning/closing files.


Thanks,

Michal Humpula


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114485/">http://git.reviewboard.kde.org/r/114485/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>


<p style="color: grey;"><i>Updated Dec. 16, 2013, 12:13 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It&#39;s mostly straighforward, but few places are guestimates.

btw, is there any transitional documentation? I tried to find info in KUrl, but there \
is not any:( Generaly lots of stuff is marked deprecated, but I can&#39;t find any \
place hinting the correct substitution. Any hint?:)</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">manualy openning/closing files.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/kateapp.h <span style="color: grey">(9775189)</span></li>

 <li>kate/app/kateapp.cpp <span style="color: grey">(7d26c62)</span></li>

 <li>kate/app/kateappcommands.cpp <span style="color: grey">(e5de9f7)</span></li>

 <li>kate/app/katedocmanager.h <span style="color: grey">(1359a20)</span></li>

 <li>kate/app/katedocmanager.cpp <span style="color: grey">(387e759)</span></li>

 <li>kate/app/katemainwindow.h <span style="color: grey">(c81c14c)</span></li>

 <li>kate/app/katemainwindow.cpp <span style="color: grey">(8a569c8)</span></li>

 <li>kate/app/katemwmodonhddialog.cpp <span style="color: grey">(bacfb03)</span></li>

 <li>kate/app/katequickopen.cpp <span style="color: grey">(e4c37d9)</span></li>

 <li>kate/app/katesavemodifieddialog.cpp <span style="color: \
grey">(4a7e47e)</span></li>

 <li>kate/app/katesession.cpp <span style="color: grey">(004dcbc)</span></li>

 <li>kate/app/kateviewmanager.h <span style="color: grey">(7a27357)</span></li>

 <li>kate/app/kateviewmanager.cpp <span style="color: grey">(429d064)</span></li>

 <li>kate/app/kateviewspace.cpp <span style="color: grey">(dc43812)</span></li>

 <li>kate/filetree/katefiletree.h <span style="color: grey">(1c4362c)</span></li>

 <li>kate/filetree/katefiletree.cpp <span style="color: grey">(6d025f4)</span></li>

 <li>kate/filetree/katefiletreemodel.cpp <span style="color: \
grey">(8d8cf07)</span></li>

 <li>kate/interfaces/kate/application.h <span style="color: \
grey">(e65e474)</span></li>

 <li>kate/interfaces/kate/documentmanager.h <span style="color: \
grey">(119a8f5)</span></li>

 <li>kate/interfaces/kate/documentmanager.cpp <span style="color: \
grey">(68a76c0)</span></li>

 <li>kate/interfaces/kate/mainwindow.h <span style="color: \
grey">(0c4be6b)</span></li>

 <li>kate/interfaces/kate/mainwindow.cpp <span style="color: \
grey">(c469627)</span></li>

 <li>kate/interfaces/kate/plugin.h <span style="color: grey">(df64d2f)</span></li>

 <li>kate/interfaces/kate/pluginmanager.h <span style="color: \
grey">(680516d)</span></li>

 <li>part/utils/katecmds.cpp <span style="color: grey">(e7da9e8)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114485/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic