'Re: Review Request 114395: add partial RST support to cmake.xml'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114395: add partial RST support to cmake.xml
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2013-12-14 19:58:27
Message-ID: 20131214195827.31701.12203 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114395/#review45701
-----------------------------------------------------------

Ship it!

Matthew, you've been working a lot with the highlighting system. I trust you know \
what you are doing. The patch looks good, so please commit.

- Dominik Haumann

On Dec. 10, 2013, 10:20 p.m., Matthew Woehlke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114395/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2013, 10:20 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Add support for quoted RST in CMake. Only quoted is supported because the other \
> syntax can't be trivially highlighted, as it relies on implicit removal of the \
> leading comment character. 
> 
> Diffs
> -----
> 
> part/syntax/data/cmake.xml a7dcebc21fa250d3b7fbf20e7951e499f73b2ea2 
> 
> Diff: http://git.reviewboard.kde.org/r/114395/diff/
> 
> 
> Testing
> -------
> 
> Tried adding some RST blocks on a CMake file; highlighting is as expected.
> 
> 
> Thanks,
> 
> Matthew Woehlke
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114395/">http://git.reviewboard.kde.org/r/114395/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Matthew, you&#39;ve been \
working a lot with the highlighting system. I trust you know what you are doing. The \
patch looks good, so please commit.</pre>  <br />

<p>- Dominik Haumann</p>

<br />
<p>On December 10th, 2013, 10:20 p.m. UTC, Matthew Woehlke wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Matthew Woehlke.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2013, 10:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add support for quoted RST in CMake. Only quoted is supported because \
the other syntax can&#39;t be trivially highlighted, as it relies on implicit removal \
of the leading comment character.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tried adding some RST blocks on a CMake file; highlighting is as \
expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/syntax/data/cmake.xml <span style="color: \
grey">(a7dcebc21fa250d3b7fbf20e7951e499f73b2ea2)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114395/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 