[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114370: vi-mode: don't change selection after "\\ctrl-vjl:"
From: "Simon St James" <kdedevel () etotheipiplusone ! com>
Date: 2013-12-10 10:04:42
Message-ID: 20131210100442.3518.50056 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114370/#review45451
-----------------------------------------------------------
Ship it!
"The little problem is, that I can't think of any command after that sequence, that \
would yield different result before and after applying this patch. Any ideas?"
Me neither - the patch is good enough as-is, though, I think :)
- Simon St James
On Dec. 9, 2013, 5:33 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114370/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2013, 5:33 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> After "\\ctrl-vjl:" the selection goes from block mode to char mode, which is a \
> little bit confusing. Changing the flags of ":" to SHOULD_NOT_RESET seems like \
> fixing it. Tests are still passing and the new one is too. The little problem is, \
> that I can't think of any command after that sequence, that would yield different \
> result before and after applying this patch. Any ideas? If it is possible to \
> execute some scripting functions trough cmdline, then it might make a difference, \
> though.
> Included few minor cleanups.
>
>
> Diffs
> -----
>
> part/vimode/katevimodebase.cpp 5ee5a86
> part/vimode/katevivisualmode.h 94ddf5d
> part/vimode/katevivisualmode.cpp 768e9c6
> tests/vimode_test.cpp 59d4362
>
> Diff: http://git.reviewboard.kde.org/r/114370/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114370/">http://git.reviewboard.kde.org/r/114370/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"The little problem \
is, that I can't think of any command after that sequence, that would yield \
different result before and after applying this patch. Any ideas?"
Me neither - the patch is good enough as-is, though, I think :)</pre>
<br />
<p>- Simon St James</p>
<br />
<p>On December 9th, 2013, 5:33 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 9, 2013, 5:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">After "\\ctrl-vjl:" the selection goes from block mode to char \
mode, which is a little bit confusing. Changing the flags of ":" to \
SHOULD_NOT_RESET seems like fixing it. Tests are still passing and the new one is \
too. The little problem is, that I can't think of any command after that \
sequence, that would yield different result before and after applying this patch. Any \
ideas? If it is possible to execute some scripting functions trough cmdline, then it \
might make a difference, though.
Included few minor cleanups.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevimodebase.cpp <span style="color: grey">(5ee5a86)</span></li>
<li>part/vimode/katevivisualmode.h <span style="color: grey">(94ddf5d)</span></li>
<li>part/vimode/katevivisualmode.cpp <span style="color: grey">(768e9c6)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(59d4362)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114370/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic