'Re: Review Request 114307: switched to dynamic downloading in js_utils'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114307: switched to dynamic downloading in js_utils
From:       "Phil Schaf" <flying-sheep () web ! de>
Date:       2013-12-10 9:40:23
Message-ID: 20131210094023.32084.4583 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114307/
-----------------------------------------------------------

(Updated Dec. 10, 2013, 9:40 a.m.)

Review request for Kate.

Changes
-------

switched to KMessageBox, ask user for download

Repository: kate

Description
-------

switched to dynamic downloading in js_utils

the fix_js() function is too flaky for my taste, but JS apparently enables you to use \
"function", "break", "var" and so on as property names for objects, e.g. the \
following is fine:

myObject = { function: function() {} }
myObject.var = 0.5

QtScript, however, disagrees, so i have to convert myObject.var to myObject["var"]. \
this might not work for all code (e.g. inside strings)

Diffs (updated)
-----

  addons/kate/pate/src/plugins/js_utils/fulljslint.js c4d8a95 
  addons/kate/pate/src/plugins/js_utils/js_engine.py 719701f 
  addons/kate/pate/src/plugins/js_utils/js_lint.py 038988c 
  addons/kate/pate/src/plugins/js_utils/jshint.js 939e4f5 

Diff: http://git.reviewboard.kde.org/r/114307/diff/

Testing
-------

tried it with JSLint and JSHint, denying and accepting the license.

PS: kate doesn't properly close down for me ATM, but AFAIK, that has nothing to do \
with my changes

Thanks,

Phil Schaf

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114307/">http://git.reviewboard.kde.org/r/114307/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Phil Schaf.</div>

<p style="color: grey;"><i>Updated Dec. 10, 2013, 9:40 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">switched to KMessageBox, ask user for download</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">switched to dynamic downloading in js_utils

the fix_js() function is too flaky for my taste, but JS apparently enables you to use \
"function", "break", "var" and so on as property names for objects, e.g. the \
following is fine:

myObject = { function: function() {} }
myObject.var = 0.5

QtScript, however, disagrees, so i have to convert myObject.var to \
myObject[&quot;var&quot;]. this might not work for all code (e.g. inside \
strings)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tried it with JSLint and JSHint, denying and accepting the license.

PS: kate doesn't properly close down for me ATM, but AFAIK, that has nothing to do \
with my changes</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>addons/kate/pate/src/plugins/js_utils/fulljslint.js <span style="color: \
grey">(c4d8a95)</span></li>

 <li>addons/kate/pate/src/plugins/js_utils/js_engine.py <span style="color: \
grey">(719701f)</span></li>

 <li>addons/kate/pate/src/plugins/js_utils/js_lint.py <span style="color: \
grey">(038988c)</span></li>

 <li>addons/kate/pate/src/plugins/js_utils/jshint.js <span style="color: \
grey">(939e4f5)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114307/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 