'Re: Review Request 114315: Warn kate user of opening large files'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114315: Warn kate user of opening large files
From:       "Alexander Neundorf" <neundorf () kde ! org>
Date:       2013-12-08 14:26:57
Message-ID: 20131208142657.17200.12320 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114315/#review45350
-----------------------------------------------------------

> Does anyone know anyone, who is opening larger files  [than 10 MB] in kate and \
> considers it to be normal?

Yes, we do that regularly at work. The size limit for our log files is set to 16MB \
currently, and we look at them quite often in kate. Ok, we all have at least 16GB or \
memory in the work machines, so we consider 16 MB small. :-)

- Alexander Neundorf

On Dec. 5, 2013, 4:53 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114315/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2013, 4:53 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Warn kate user of opening large files, which could lead to unresponsive kate and \
> potential loss of unsaved changes, due to the "killall -9 kate" action, that would \
> most likely come after 1min of waiting. 
> The very likely usecase goes like this:
> "Have you ever accidentaly openned large mkv file instead of srt one in the same \
> folder?" 
> Limit of 10MB seems enought to not bother the user with regular files. Does anyone \
> know anyone, who is opening larger files in kate and considers it to be normal? 
> Thanks Sven Brauch and Gerald Senarclens de Grancy for suggesting the correct \
> solution. 
> 
> Diffs
> -----
> 
> kate/app/kateviewmanager.cpp 2dbd1f9 
> 
> Diff: http://git.reviewboard.kde.org/r/114315/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114315/">http://git.reviewboard.kde.org/r/114315/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&gt; Does anyone know \
anyone, who is opening larger files  [than 10 MB] in kate and considers it to be \
normal?

Yes, we do that regularly at work. The size limit for our log files is set to 16MB \
currently, and we look at them quite often in kate. Ok, we all have at least 16GB or \
memory in the work machines, so we consider 16 MB small. :-) </pre>
 <br />

<p>- Alexander Neundorf</p>

<br />
<p>On December 5th, 2013, 4:53 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 5, 2013, 4:53 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Warn kate user of opening large files, which could lead to unresponsive \
kate and potential loss of unsaved changes, due to the &quot;killall -9 kate&quot; \
action, that would most likely come after 1min of waiting.

The very likely usecase goes like this:
&quot;Have you ever accidentaly openned large mkv file instead of srt one in the same \
folder?&quot;

Limit of 10MB seems enought to not bother the user with regular files. Does anyone \
know anyone, who is opening larger files in kate and considers it to be normal?

Thanks Sven Brauch and Gerald Senarclens de Grancy for suggesting the correct \
solution.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kate/app/kateviewmanager.cpp <span style="color: grey">(2dbd1f9)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114315/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 