[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114212: vi-mode: fix some finnish keys
From: Erlend Hamberg <ehamberg () gmail ! com>
Date: 2013-12-05 13:00:16
Message-ID: CA+G9OXmf9L8ow57hmM=x4fT=FUpe15y8L6_U=2ssdd_KUi+tYA () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Aaaand the email bounced. The mystery remains unsolved. :/
Erlend
On 5 December 2013 13:58, Erlend Hamberg <ehamberg@gmail.com> wrote:
> Looks like it comes from this commit (but has since been changed a bit):
>
>
> http://quickgit.kde.org/?p=kate.git&a=commit&h=348a59e119020b36c2da2baffb5f0bc3b7f48ec3
>
> Could you remind us of how this should work, Evgeniy? (CC'ed)
>
> It's only been five years ;-)
>
> Erlend
>
>
> On 4 December 2013 21:17, Michal Humpula <michal.humpula@seznam.cz> \
> wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/114212/
> >
> > On December 4th, 2013, 6:26 p.m. UTC, *Erlend Hamberg* wrote:
> >
> > As far as I remember, it was added to make sure that people using \
> > Cyrillic, Greek and other non-latin keyboard layouts are able to use \
> > the Vi mode. Since I have never used a non-latin layout myself, I might \
> > get this wrong, but I believe that when a user of, e.g. a Cyrillic \
> > keyboard presses the (physical) ?/j key, it should insert "?" in insert \
> > mode, but go down a line if in normal mode, thus making it possible to \
> > use the Vi mode without creating mapping for every vi command. As far \
> > as I remember, I was told that this is also how Vim works.
> > On December 4th, 2013, 6:38 p.m. UTC, *Erlend Hamberg* wrote:
> >
> > Gah, it looks like reviewboard replaced the cyrillic characters with \
> > question marks. Stupid, stupid reviewboard! :)
> > On December 4th, 2013, 6:41 p.m. UTC, *Michal Humpula* wrote:
> >
> > yeah, but email contains correct characters:) Btw, that's nice \
> > explanation:) Will test that and try come up with adjusted patch, \
> > thanks!
> > wierd. I've just tried to switch keyboard to russian one trought the \
> > KDE keyboard module and go for vim (v7.4). And in normal mode the hjkl \
> > (ÒÏÌÄ) keys don't move cursor. Tried even start in compatible mode and \
> > to be sure check the gvim too. Same thing. So... what now? Do we have \
> > any "non-latin keyboard" hacker on board, who could give us the hints?
> >
> > - Michal
> >
> > On December 4th, 2013, 1:08 p.m. UTC, Michal Humpula wrote:
> > Review request for Kate and Erlend Hamberg.
> > By Michal Humpula.
> >
> > *Updated Dec. 4, 2013, 1:08 p.m.*
> > *Bugs: * 298726 <http://bugs.kde.org/show_bug.cgi?id=298726>
> > *Repository: * kate
> > Description
> >
> > ehm... I swear it doesn't break any tests on my setup and all my \
> > keyboard layouts work as they should (en, cz, fin). Can anyone explain \
> > me, what was the part that patch deletes supposed to do?:-)
> > Diffs
> >
> > - part/vimode/katevikeyparser.cpp (bfef2a8)
> >
> > View Diff <http://git.reviewboard.kde.org/r/114212/diff/>
> >
>
>
>
> --
> Erlend Hamberg
> ehamberg@gmail.com
>
--
Erlend Hamberg
ehamberg@gmail.com
[Attachment #5 (text/html)]
<div dir="ltr">Aaaand the email bounced. The mystery remains unsolved. \
:/<div><br></div><div>Erlend</div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On 5 December 2013 \
13:58, Erlend Hamberg <span dir="ltr"><<a \
href="mailto:ehamberg@gmail.com" \
target="_blank">ehamberg@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><div dir="ltr">
<p>Looks like it comes from this commit (but has since been changed a \
bit):</p><p><a href="http://quickgit.kde.org/?p=kate.git&a=commit&h=348a59e119020b36c2da2baffb5f0bc3b7f48ec3" \
target="_blank">http://quickgit.kde.org/?p=kate.git&a=commit&h=348a59e119020b36c2da2baffb5f0bc3b7f48ec3</a><br>
</p><p>Could you remind us of how this should work, Evgeniy? \
(CC'ed)</p><p>It's only been five years ;-)</p><p>Erlend</p>
</div><div class="gmail_extra"><div><div class="h5"><br><br><div \
class="gmail_quote">On 4 December 2013 21:17, Michal Humpula <span \
dir="ltr"><<a href="mailto:michal.humpula@seznam.cz" \
target="_blank">michal.humpula@seznam.cz</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div>
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px \
#c9c399 solid"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114212/" \
target="_blank">http://git.reviewboard.kde.org/r/114212/</a> </td>
</tr>
</tbody></table>
<br>
</div><blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"><div> <p style="margin-top:0">On December 4th, \
2013, 6:26 p.m. UTC, <b>Erlend Hamberg</b> wrote:</p> <blockquote \
style="margin-left:1em;border-left:2px solid #d0d0d0;padding-left:10px"> \
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">As \
far as I remember, it was added to make sure that people using Cyrillic, \
Greek and other non-latin keyboard layouts are able to use the Vi mode. \
Since I have never used a non-latin layout myself, I might get this wrong, \
but I believe that when a user of, e.g. a Cyrillic keyboard presses the \
(physical) ?/j key, it should insert “?” in insert mode, but go \
down a line if in normal mode, thus making it possible to use the Vi mode \
without creating mapping for every vi command. As far as I remember, I was \
told that this is also how Vim works.</pre>
</blockquote>
<p>On December 4th, 2013, 6:38 p.m. UTC, <b>Erlend Hamberg</b> wrote:</p>
<blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Gah, \
it looks like reviewboard replaced the cyrillic characters with question \
marks. Stupid, stupid reviewboard! :)</pre>
</blockquote>
</div><div><p>On December 4th, 2013, 6:41 p.m. UTC, <b>Michal Humpula</b> \
wrote:</p> <blockquote style="margin-left:1em;border-left:2px solid \
#d0d0d0;padding-left:10px"> <pre \
style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">yeah, \
but email contains correct characters:) Btw, that's nice explanation:) \
Will test that and try come up with adjusted patch, thanks!</pre>
</blockquote>
</div></blockquote>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">wierd. \
I've just tried to switch keyboard to russian one trought the KDE \
keyboard module and go for vim (v7.4). And in normal mode the hjkl (ÒÏÌÄ) \
keys don't move cursor. Tried even start in compatible mode and to be \
sure check the gvim too. Same thing. So... what now? Do we have any \
"non-latin keyboard" hacker on board, who could give us the \
hints?</pre>
<span><font color="#888888">
<br>
<p>- Michal</p></font></span><div>
<br>
<p>On December 4th, 2013, 1:08 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image:url('');background-repeat:repeat-x;border:1px \
black solid"> <tbody><tr>
<td>
<div>Review request for Kate and Erlend Hamberg.</div>
<div>By Michal Humpula.</div>
<p style="color:grey"><i>Updated Dec. 4, 2013, 1:08 p.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=298726" \
target="_blank">298726</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kate
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border:1px solid #b8b5a0"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">ehm... \
I swear it doesn't break any tests on my setup and all my keyboard \
layouts work as they should (en, cz, fin). Can anyone explain me, what was \
the part that patch deletes supposed to do?:-)</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>part/vimode/katevikeyparser.cpp <span \
style="color:grey">(bfef2a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114212/diff/" \
style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div>
</div>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span \
class="HOEnZb"><font color="#888888">-- <br>Erlend Hamberg<br><a \
href="mailto:ehamberg@gmail.com" target="_blank">ehamberg@gmail.com</a><br> \
</font></span></div> </blockquote></div><br><br \
clear="all"><div><br></div>-- <br>Erlend Hamberg<br><a \
href="mailto:ehamberg@gmail.com">ehamberg@gmail.com</a><br> </div>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic