[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114212: vi-mode: fix some finnish keys
From: "Michal Humpula" <michal.humpula () seznam ! cz>
Date: 2013-12-04 18:41:47
Message-ID: 20131204184147.7931.83729 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 4, 2013, 6:26 p.m., Erlend Hamberg wrote:
> > As far as I remember, it was added to make sure that people using Cyrillic, Greek \
> > and other non-latin keyboard layouts are able to use the Vi mode. Since I have \
> > never used a non-latin layout myself, I might get this wrong, but I believe that \
> > when a user of, e.g. a Cyrillic keyboard presses the (physical) ?/j key, it \
> > should insert "?" in insert mode, but go down a line if in normal mode, thus \
> > making it possible to use the Vi mode without creating mapping for every vi \
> > command. As far as I remember, I was told that this is also how Vim works.
>
> Erlend Hamberg wrote:
> Gah, it looks like reviewboard replaced the cyrillic characters with question \
> marks. Stupid, stupid reviewboard! :)
yeah, but email contains correct characters:) Btw, that's nice explanation:) Will \
test that and try come up with adjusted patch, thanks!
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114212/#review45127
-----------------------------------------------------------
On Dec. 4, 2013, 1:08 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114212/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2013, 1:08 p.m.)
>
>
> Review request for Kate and Erlend Hamberg.
>
>
> Bugs: 298726
> http://bugs.kde.org/show_bug.cgi?id=298726
>
>
> Repository: kate
>
>
> Description
> -------
>
> ehm... I swear it doesn't break any tests on my setup and all my keyboard layouts \
> work as they should (en, cz, fin). Can anyone explain me, what was the part that \
> patch deletes supposed to do?:-)
>
> Diffs
> -----
>
> part/vimode/katevikeyparser.cpp bfef2a8
>
> Diff: http://git.reviewboard.kde.org/r/114212/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114212/">http://git.reviewboard.kde.org/r/114212/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 4th, 2013, 6:26 p.m. UTC, <b>Erlend \
Hamberg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As far as I remember, it was added to make sure that people using \
Cyrillic, Greek and other non-latin keyboard layouts are able to use the Vi mode. \
Since I have never used a non-latin layout myself, I might get this wrong, but I \
believe that when a user of, e.g. a Cyrillic keyboard presses the (physical) ?/j key, \
it should insert "?" in insert mode, but go down a line if in normal mode, thus \
making it possible to use the Vi mode without creating mapping for every vi command. \
As far as I remember, I was told that this is also how Vim works.</pre> \
</blockquote>
<p>On December 4th, 2013, 6:38 p.m. UTC, <b>Erlend Hamberg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Gah, it looks like \
reviewboard replaced the cyrillic characters with question marks. Stupid, stupid \
reviewboard! :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yeah, but email contains \
correct characters:) Btw, that's nice explanation:) Will test that and try come \
up with adjusted patch, thanks!</pre> <br />
<p>- Michal</p>
<br />
<p>On December 4th, 2013, 1:08 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Erlend Hamberg.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Dec. 4, 2013, 1:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=298726">298726</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ehm... I swear it doesn't break any tests on my setup and all my \
keyboard layouts work as they should (en, cz, fin). Can anyone explain me, what was \
the part that patch deletes supposed to do?:-)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevikeyparser.cpp <span style="color: grey">(bfef2a8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114212/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic