'Re: Review Request 114251: kateviewinternal small cleanup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114251: kateviewinternal small cleanup
From:       "Commit Hook" <null () kde ! org>
Date:       2013-12-04 13:56:30
Message-ID: 20131204135630.23471.74334 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114251/#review45097
-----------------------------------------------------------

This review has been submitted with commit 0d8af77db680f21f34afb6fdfe87cf1296691e8b \
by Michal Humpula to branch master.

- Commit Hook

On Dec. 2, 2013, 1:15 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114251/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2013, 1:15 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Small cleanup of KateViewInternal
> 
> * m_smartDirty -- never assigned to be true, always false
> * m_updatingView -- never readed
> * KateViewInternal::scrollColumns() -- test the boundaries and if not srolling \
>                 return
> * KateViewInternal::resizeEvent() -- don't fire the displayRangeChanged twice
> 
> 
> Diffs
> -----
> 
> part/view/kateviewinternal.h e484093 
> part/view/kateviewinternal.cpp a0b5ce0 
> 
> Diff: http://git.reviewboard.kde.org/r/114251/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114251/">http://git.reviewboard.kde.org/r/114251/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 0d8af77db680f21f34afb6fdfe87cf1296691e8b by Michal Humpula to \
branch master.</pre>  <br />

<p>- Commit Hook</p>

<br />
<p>On December 2nd, 2013, 1:15 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 2, 2013, 1:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Small cleanup of KateViewInternal

* m_smartDirty -- never assigned to be true, always false
* m_updatingView -- never readed
* KateViewInternal::scrollColumns() -- test the boundaries and if not srolling return
* KateViewInternal::resizeEvent() -- don&#39;t fire the displayRangeChanged \
twice</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/view/kateviewinternal.h <span style="color: grey">(e484093)</span></li>

 <li>part/view/kateviewinternal.cpp <span style="color: grey">(a0b5ce0)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114251/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 