'Re: Review Request 114168: vi-mode: idea about the cmd line'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114168: vi-mode: idea about the cmd line
From:       "Dominik Haumann" <dhaumann () kde ! org>
Date:       2013-12-04 13:17:05
Message-ID: 20131204131705.15081.12942 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114168/#review45091
-----------------------------------------------------------

As I understand, the viewbar then will appear right above the horizontal scroll bar, \
correct?

Can you add a screenshot?

- Dominik Haumann

On Nov. 27, 2013, 8:38 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114168/
> -----------------------------------------------------------
> 
> (Updated Nov. 27, 2013, 8:38 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> This is just a proof of concept (or an examplary code if you want), that's why it \
> cuts through the necessary parts without beeing carefull. 
> As vim user I'm used to cmdline to be as close to actual text as possible. The \
> patch make the (new one) cmdline move exactly below the column scrollbar as close \
> to view as possible. 
> Opinions are welcomed.
> 
> 
> Diffs
> -----
> 
> part/view/kateview.cpp b321d9b 
> part/vimode/kateviemulatedcommandbar.h 6f87ed7 
> part/vimode/kateviemulatedcommandbar.cpp ed6e4e7 
> 
> Diff: http://git.reviewboard.kde.org/r/114168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114168/">http://git.reviewboard.kde.org/r/114168/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As I understand, the \
viewbar then will appear right above the horizontal scroll bar, correct?

Can you add a screenshot?</pre>
 <br />

<p>- Dominik Haumann</p>

<br />
<p>On November 27th, 2013, 8:38 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Nov. 27, 2013, 8:38 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is just a proof of concept (or an examplary code if you want), \
that&#39;s why it cuts through the necessary parts without beeing carefull.

As vim user I&#39;m used to cmdline to be as close to actual text as possible. The \
patch make the (new one) cmdline move exactly below the column scrollbar as close to \
view as possible.

Opinions are welcomed.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/view/kateview.cpp <span style="color: grey">(b321d9b)</span></li>

 <li>part/vimode/kateviemulatedcommandbar.h <span style="color: \
grey">(6f87ed7)</span></li>

 <li>part/vimode/kateviemulatedcommandbar.cpp <span style="color: \
grey">(ed6e4e7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114168/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 