'Re: Review Request 114276: KateDocument->closeUrl speedup'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114276: KateDocument->closeUrl speedup
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2013-12-03 20:09:40
Message-ID: 20131203200940.30185.81039 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114276/#review45052
-----------------------------------------------------------

Well, the document did change its url - no? You can close a document and open another \
file in it after all.

What you might want is an "about to delete/shutdown" kind of flag in which case this \
might be a valid optimization.

Then again, 500 files in Kate? Are you seriously doing this?

- Milian Wolff

On Dec. 3, 2013, 4:26 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114276/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 4:26 p.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Is it really necesary to `updateDocName` when we just finished closing the document \
> (and destroying all its highlits, marks, ...)? 
> Testing environment: openned session of size 500 files; *.cpp an *.h files from \
> kate src tree, nothing is dirty. The "New Session" takes 23 seconds. Half of that \
> time is spent in KateFileTree plugin (computating colors) called from document name \
> updating. 
> All the tests are passing. So is there any scenario, where this patch would yield \
> wrong behaviour, e.g. can client call closeUrl and expect document still work as if \
> nothing happened? 
> 
> Diffs
> -----
> 
> part/document/katedocument.cpp dad52bb 
> 
> Diff: http://git.reviewboard.kde.org/r/114276/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114276/">http://git.reviewboard.kde.org/r/114276/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, the document did \
change its url - no? You can close a document and open another file in it after all.

What you might want is an &quot;about to delete/shutdown&quot; kind of flag in which \
case this might be a valid optimization.

Then again, 500 files in Kate? Are you seriously doing this?</pre>
 <br />

<p>- Milian Wolff</p>

<br />
<p>On December 3rd, 2013, 4:26 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Dec. 3, 2013, 4:26 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Is it really necesary to `updateDocName` when we just finished closing \
the document (and destroying all its highlits, marks, ...)?

Testing environment: openned session of size 500 files; *.cpp an *.h files from kate \
src tree, nothing is dirty. The &quot;New Session&quot; takes 23 seconds. Half of \
that time is spent in KateFileTree plugin (computating colors) called from document \
name updating.

All the tests are passing. So is there any scenario, where this patch would yield \
wrong behaviour, e.g. can client call closeUrl and expect document still work as if \
nothing happened?</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/document/katedocument.cpp <span style="color: grey">(dad52bb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114276/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 