[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114215: vi-mode: mouse insert/visual mode behaviour correction
From: "Simon St James" <kdedevel () etotheipiplusone ! com>
Date: 2013-11-30 10:07:01
Message-ID: 20131130100701.31697.95300 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114215/#review44871
-----------------------------------------------------------
Ship it!
Looks good to me - thanks for all the great patches!
- Simon St James
On Nov. 29, 2013, 8:51 p.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114215/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2013, 8:51 p.m.)
>
>
> Review request for Kate.
>
>
> Bugs: 325466
> http://bugs.kde.org/show_bug.cgi?id=325466
>
>
> Repository: kate
>
>
> Description
> -------
>
> when going from insert mode to visual mode by mouse text selection, when \
> deselecting by mouse clicking return to insert mode:-)
> The patch is probably more understandable then the explanation. Solves only half of \
> the linked bug report.
> The tests are included.
>
>
> Diffs
> -----
>
> part/vimode/kateviinputmodemanager.h 9ec9654
> part/vimode/kateviinputmodemanager.cpp 18412e6
> part/vimode/katevivisualmode.cpp bc09af4
> tests/vimode_test.cpp 4cef23e
>
> Diff: http://git.reviewboard.kde.org/r/114215/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114215/">http://git.reviewboard.kde.org/r/114215/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me - \
thanks for all the great patches!</pre> <br />
<p>- Simon St James</p>
<br />
<p>On November 29th, 2013, 8:51 p.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2013, 8:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=325466">325466</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">when going from insert mode to visual mode by mouse text selection, when \
deselecting by mouse clicking return to insert mode:-)
The patch is probably more understandable then the explanation. Solves only half of \
the linked bug report.
The tests are included.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/kateviinputmodemanager.h <span style="color: \
grey">(9ec9654)</span></li>
<li>part/vimode/kateviinputmodemanager.cpp <span style="color: \
grey">(18412e6)</span></li>
<li>part/vimode/katevivisualmode.cpp <span style="color: grey">(bc09af4)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(4cef23e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114215/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic