[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Pascal Test Suite
From:       Albert Astals Cid <aacid () kde ! org>
Date:       2013-11-27 20:55:41
Message-ID: 3678392.1r2qL8PqRa () xps
[Download RAW message or body]

El Diumenge, 24 de novembre de 2013, a les 12:40:30, Dominik Haumann va 
escriure:
> On Saturday 23 November 2013 20:50:43 trevor wrote:
> > Hi Dominik,
> > 
> > try the diffs attached.
> > I have replaced the 2 tests with 4 that are each much shorter - the new
> > tests are called longtest{1,2,3,4}
> > (plus a few other minor mods and new tests)
> > 
> > It now takes me about 5 secs to run the whole pascal test - is that OK?
> 
> Yes, that's much better! :-) Do you commit, or shall I commit for you?

Can you please also fix that in KDE/4.12 so we have a passing test suite on 
the branch we are going to release in 2 weeks?

Cheers,
  Albert

> 
> Greetings,
> Dominik
> 
> > On 22/11/13 10:53, Dominik Haumann wrote:
> > > Hi Trevor,
> > > 
> > > currently, the indenter unit test times out because of the pascal indent
> > > test test{1,2,3}:
> > > 
> > > http://build.kde.org/job/kate_stable/251/testReport/(root)/TestSuite/kat
> > > e_
> > > indenttest/
> > > 
> > > All of Kate is automatically compiled after every commit, and the unit
> > > test
> > > suite is then executed. So all in all, the tests should be as short as
> > > possible.
> > > 
> > > Can you either heavily trim the unit tests to just test what you really
> > > want to test? Otherwise, we have to remove these big tests.
> > > 
> > > Best,
> > > Dominik
> 
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]