'Re: Review Request 114136: Add command g~~ in vimode'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114136: Add command g~~ in vimode
From:       "Simon St James" <kdedevel () etotheipiplusone ! com>
Date:       2013-11-26 11:06:23
Message-ID: 20131126110623.17161.29786 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114136/#review44487
-----------------------------------------------------------

Can you add automated tests in vimode_test.cpp, please? Just after:

// Testing "g~"

Things like not doing anything on a blank line/ empty doc; positioning cursor \
appropriately afterwards; etc

Thanks!

- Simon St James

On Nov. 26, 2013, 10:56 a.m., Harsh Kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114136/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2013, 10:56 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Add vi command 'g~~' : To toggle the case of a line.
> 
> 
> Diffs
> -----
> 
> part/vimode/katevinormalmode.h 1ff0953 
> part/vimode/katevinormalmode.cpp 85083f4 
> 
> Diff: http://git.reviewboard.kde.org/r/114136/diff/
> 
> 
> Testing
> -------
> 
> I started kate & tried out this command in a few files. It works as expected.
> 
> 
> Thanks,
> 
> Harsh Kumar
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114136/">http://git.reviewboard.kde.org/r/114136/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can you add automated \
tests in vimode_test.cpp, please? Just after:

// Testing &quot;g~&quot;

Things like not doing anything on a blank line/ empty doc; positioning cursor \
appropriately afterwards; etc

Thanks!</pre>
 <br />

<p>- Simon St James</p>

<br />
<p>On November 26th, 2013, 10:56 a.m. UTC, Harsh Kumar wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2013, 10:56 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add vi command &#39;g~~&#39; : To toggle the case of a line.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I started kate &amp; tried out this command in a few files. It works as \
expected.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevinormalmode.h <span style="color: grey">(1ff0953)</span></li>

 <li>part/vimode/katevinormalmode.cpp <span style="color: grey">(85083f4)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114136/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 