Dear Pate plugin developers,

We need to get into the habit of ensuring the KDE i18n() rules are followed to allow the translators to do their job! Please see the attached note from Burkhard and take cae of the stuff you own in master (4.12 is done and dusted).

This was always a bit tricky with the old way of doing things, but AFAIK, the work that Alex has done in terms of using .ui files and .desktop files should greatly simplify and clarify what is needed. If you are unclear as to what is needed, please feel free to ask (I'm not an expert, but I'm sure that won't be a barrier :-)).

(BTW, Burkhard, the last 3 items which you mentioned are pending review/removal in master, that's why I have not applied the fixes form 4.12 to them).

Thanks, Shaheed


On 25 November 2013 12:48, Burkhard Lueck <lueck@hube-lueck.de> wrote:
https://bugs.kde.org/show_bug.cgi?id=313809

Burkhard Lueck <lueck@hube-lueck.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---

--- Comment #37 from Burkhard Lueck <lueck@hube-lueck.de> ---
No this is NOT resolved, these strings are translatable in 4.12, but not
extracted and untranslatable in master now:

./plugins/block_ui.rc:13:                <Action name="insertCharFromLineAbove"
text="Insert Char From Line Above" shortcut="Meta+E" />
./plugins/block_ui.rc:14:                <Action name="insertCharFromLineBelow"
text="Insert Char From Line Below" shortcut="Meta+W" />
./plugins/block_ui.rc:16:                <Action name="killRestOfLine"
text="Kill Text After Cursor" shortcut="Meta+K" />
./plugins/block_ui.rc:17:                <Action name="killLeadOfLine"
text="Kill Text Before Cursor" shortcut="Meta+U" />
./plugins/block_ui.rc:19:                <Action
name="wrapBlockWithRoundBrackets" text="Wrap into Round Brackets"
shortcut="Ctrl+(" />
./plugins/block_ui.rc:20:                <Action
name="wrapBlockWithSquareBrackets" text="Wrap into Square Brackets"
shortcut="Ctrl+{" />
./plugins/block_ui.rc:21:                <Action
name="wrapBlockWithCurveBrackets" text="Wrap into Curve Brackets"
shortcut="Meta+{" />
./plugins/block_ui.rc:22:                <Action
name="wrapBlockWithAngleBrackets" text="Wrap into Angle Brackets"
shortcut="Ctrl+&lt;" />
./plugins/block_ui.rc:23:                <Action name="wrapBlockWithDblQuotes"
text="Wrap into Double Quotes" shortcut="Ctrl+'" />
./plugins/block_ui.rc:24:                <Action name="wrapBlockWithQuotes"
text="Wrap into Quotes" shortcut="Meta+'" />
./plugins/js_utils/js_utils_ui.rc:11:            <Action name="lint_js_action"
text="Lint JavaScript" shortcut="Alt+9" />
./plugins/js_utils/js_utils_ui.rc:12:            <Action
name="insert_jquery_ready_action" text="jQuery Ready" shortcut="Ctrl+Shift+J"
/>
./plugins/js_utils/js_utils_ui.rc:13:            <Action
name="prettify_JSON_action" text="Prettify JSON" shortcut="Ctrl+Alt+J" />
./plugins/commentar_ui.rc:14:                <Action name="inline_comment"
text="Inline Comment" shortcut="Alt+D" />
./plugins/commentar_ui.rc:15:                <Action name="move_above"
text="Move Comment Above" shortcut="Meta+Left" />
./plugins/commentar_ui.rc:16:                <Action name="move_inline"
text="Move Comment Inline" shortcut="Meta+Right" />
./plugins/commentar_ui.rc:18:                <Action name="comment_block"
text="Comment Block with #if0" shortcut="Meta+D" />
./plugins/commentar_ui.rc:19:                <Action name="toggle_block"
text="Toggle #if0/#if1 Block" shortcut="Meta+Shift+D" />
./plugins/commentar_ui.rc:20:                <Action name="remove_block"
text="Remove #if0/#if1 Block" shortcut="Meta+R" />
./plugins/commentar_ui.rc:21:                <Action name="select_block"
text="Select Current #if0/#if1 Block" shortcut="Meta+S" />
./plugins/commentar_ui.rc:23:                <Action name="toggle_doxy_comment"
text="Transform Doxygen Comments" shortcut="Meta+X" />
./plugins/commentar_ui.rc:25:                <Action name="shrink_paragraph"
text="Shrink Comment Paragraph" shortcut="Meta+[" />
./plugins/commentar_ui.rc:26:                <Action name="extend_paragraph"
text="Extend Comment Paragraph" shortcut="Meta+]" />
./plugins/gid/gid_ui.rc:12:            <Action name="show" text="Browse Tokens"
shortcut="Alt+1" icon="edit-find" />
./plugins/gid/gid_ui.rc:13:            <Action name="lookup" text="Lookup
Current Token" shortcut="Alt+2" icon="edit-find" />
./plugins/gid/gid_ui.rc:14:            <Action name="gotoDefinition" text="Go
to Definition" shortcut="Alt+3" icon="go-jump-definition" />
./plugins/expand_ui.rc:12:            <Action name="expandAtCursor"
text="Expand" shortcut="Ctrl+E" group="bottom_tools_operations" />
./plugins/expand_ui.rc:13:            <Action name="getHelpOnExpandAtCursor"
text="Expand Usage" shortcut="Shift+Ctrl+E" group="bottom_tools_operations" />
./plugins/xml_pretty_ui.rc:11:            <Action name="prettyXMLFormat"
text="Pretty XML" shortcut="Ctrl+Alt+X" />
./ui.rc:16:            <Action name="about_pate" text="About Pate"
icon="python" />


And some more missing i18n() calls in master:

$ git diff plugins/
diff --git a/addons/kate/pate/src/plugins/python_utils/python_settings.py
b/addons/kate/pate/src/plugins/python_utils/python_settings.py
index e0b2e40..aae6c4c 100644
--- a/addons/kate/pate/src/plugins/python_utils/python_settings.py
+++ b/addons/kate/pate/src/plugins/python_utils/python_settings.py
@@ -23,7 +23,7 @@ PY_MENU = "Python"
 PY_CHECKERS = i18n("Checkers")

 KATE_ACTIONS = {
-    'insertIPDB': {'text': 'ipdb', 'shortcut': 'Ctrl+I',
+    'insertIPDB': {'text': i18n('ipdb'), 'shortcut': 'Ctrl+I',
                    'menu': PY_MENU, 'icon': 'tools-report-bug'},
     'insertInit': {'text': i18n('__init__ method'), 'shortcut': 'Ctrl+,',
                    'menu': PY_MENU, 'icon': None},
@@ -33,11 +33,11 @@ KATE_ACTIONS = {
                       'menu': PY_MENU, 'icon': None},
     'checkAll': {'text': i18n('Check all'), 'shortcut': 'Alt+5',
                  'menu': PY_CHECKERS, 'icon': None},
-    'checkPyflakes': {'text': 'Pyflakes', 'shortcut': 'Alt+7',
+    'checkPyflakes': {'text': i18n('Pyflakes'), 'shortcut': 'Alt+7',
                       'menu': PY_CHECKERS, 'icon': None},
     'parseCode': {'text': i18n('Syntax Errors'), 'shortcut': 'Alt+6',
                   'menu': PY_CHECKERS, 'icon': None},
-    'checkPep8': {'text': 'Pep8', 'shortcut': 'Alt+8',
+    'checkPep8': {'text': i18n('Pep8'), 'shortcut': 'Alt+8',
                   'menu': PY_CHECKERS, 'icon': None},
 }

diff --git a/addons/kate/pate/src/plugins/xml_pretty.py
b/addons/kate/pate/src/plugins/xml_pretty.py
index 5ef2180..99f5be6 100644
--- a/addons/kate/pate/src/plugins/xml_pretty.py
+++ b/addons/kate/pate/src/plugins/xml_pretty.py
@@ -38,7 +38,7 @@ from libkatepate.decorators import *


 KATE_CONFIG = {'name': 'XML Pretty',
-               'fullName': 'XML Pretty',
+               'fullName': i18n('XML Pretty'),
                'icon': 'text-xml'}

 _CONFIG_UI = 'xml_pretty.ui'

--
You are receiving this mail because:
You are on the CC list for the bug.