[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 114061: fix vi-mode indent so we get expected result when undoing
From: "Michal Humpula" <michal.humpula () hudrydum ! cz>
Date: 2013-11-24 18:10:18
Message-ID: 20131124181018.13553.33069 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 24, 2013, 11:01 a.m., Simon St James wrote:
> > Hehe :) Yep, go ahead and commit :)
>
> Michal Humpula wrote:
> Looking at the developer application form... should I fill you as supporter?
>
> Simon St James wrote:
> I tried to respond via e-mail, but it kept bouncing ...
>
> Yes, please go ahead - you've got a nice number of good patches, here, so I'm happy \
> vouch for you :)
email here is old (though it may be reborn in few month). I've tried to update it, \
but can't find the damn email change field. Thanks for vouching. I sincerely hope I \
will not screw the repository up:-D
- Michal
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114061/#review44304
-----------------------------------------------------------
On Nov. 24, 2013, 10:54 a.m., Michal Humpula wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114061/
> -----------------------------------------------------------
>
> (Updated Nov. 24, 2013, 10:54 a.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> Testing from the gui seems that patch yield correct results. But the actual \
> testcases added in the patch fail and I have no idea why. Any idea?
>
> Diffs
> -----
>
> part/vimode/katevinormalmode.cpp 27654a5
> tests/vimode_test.cpp 9af08bc
>
> Diff: http://git.reviewboard.kde.org/r/114061/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michal Humpula
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/114061/">http://git.reviewboard.kde.org/r/114061/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 24th, 2013, 11:01 a.m. UTC, <b>Simon \
St James</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hehe :) Yep, go ahead and commit :)</pre> </blockquote>
<p>On November 24th, 2013, 11:16 a.m. UTC, <b>Michal Humpula</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looking at the developer \
application form... should I fill you as supporter?</pre> </blockquote>
<p>On November 24th, 2013, 4:55 p.m. UTC, <b>Simon St James</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to respond via \
e-mail, but it kept bouncing ...
Yes, please go ahead - you've got a nice number of good patches, here, so I'm \
happy vouch for you :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">email here is old \
(though it may be reborn in few month). I've tried to update it, but can't \
find the damn email change field. Thanks for vouching. I sincerely hope I will not \
screw the repository up:-D</pre> <br />
<p>- Michal</p>
<br />
<p>On November 24th, 2013, 10:54 a.m. UTC, Michal Humpula wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>
<p style="color: grey;"><i>Updated Nov. 24, 2013, 10:54 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing from the gui seems that patch yield correct results. But the \
actual testcases added in the patch fail and I have no idea why. Any idea?</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(27654a5)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(9af08bc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/114061/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic