'Re: Review Request 114061: fix vi-mode indent so we get expected result when undoing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114061: fix vi-mode indent so we get expected result when undoing
From:       "Simon St James" <kdedevel () etotheipiplusone ! com>
Date:       2013-11-24 10:25:31
Message-ID: 20131124102531.21412.28494 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114061/#review44300
-----------------------------------------------------------

Ship it!

"Any idea?"

I've just fixed this with 

http://commits.kde.org/kate/3cb555e61b021fb3dbbfe314f13ccfb8deea32bc

Thanks for the patch! Incidentally, you have a couple of review requests that have \
passed review, so please commit these to master too if you have a KDE git account.  \
If you don't have one, go ahead and get one ;)

- Simon St James

On Nov. 24, 2013, 9:46 a.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114061/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2013, 9:46 a.m.)
> 
> 
> Review request for Kate.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> Testing from the gui seems that patch yield correct results. But the actual \
> testcases added in the patch fail and I have no idea why. Any idea? 
> 
> Diffs
> -----
> 
> part/vimode/katevinormalmode.cpp 27654a5 
> tests/vimode_test.cpp 9af08bc 
> 
> Diff: http://git.reviewboard.kde.org/r/114061/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114061/">http://git.reviewboard.kde.org/r/114061/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&quot;Any idea?&quot;

I&#39;ve just fixed this with 

http://commits.kde.org/kate/3cb555e61b021fb3dbbfe314f13ccfb8deea32bc

Thanks for the patch! Incidentally, you have a couple of review requests that have \
passed review, so please commit these to master too if you have a KDE git account.  \
If you don&#39;t have one, go ahead and get one ;)</pre>  <br />

<p>- Simon St James</p>

<br />
<p>On November 24th, 2013, 9:46 a.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Nov. 24, 2013, 9:46 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing from the gui seems that patch yield correct results. But the \
actual testcases added in the patch fail and I have no idea why. Any idea?</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevinormalmode.cpp <span style="color: grey">(27654a5)</span></li>

 <li>tests/vimode_test.cpp <span style="color: grey">(9af08bc)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114061/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 