'Re: Review Request 114032: Proper handling of Del key'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 114032: Proper handling of Del key
From:       "Simon St James" <kdedevel () etotheipiplusone ! com>
Date:       2013-11-23 17:54:15
Message-ID: 20131123175415.22084.32368 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114032/#review44277
-----------------------------------------------------------

Since this patch has been rolled into https://git.reviewboard.kde.org/r/114033/, this \
can probably be closed, now.

- Simon St James

On Nov. 23, 2013, 5:50 p.m., Michal Humpula wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114032/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 5:50 p.m.)
> 
> 
> Review request for Kate, Erlend Hamberg and Simon St James.
> 
> 
> Repository: kate
> 
> 
> Description
> -------
> 
> For some reason (Qt, key config, keyboard, kernel, X, I don't know...) when I hit \
> the Del key the QKeyEvent->text() contains some weirdly looking unicode character. \
> So naturally the del key is not behaving for me properly. The patch makes sure, it \
> does. 
> I have no idea how to write a test for this. Though I will be sending another patch \
> with del keys extended with tests, so it might be just fine. 
> 
> Diffs
> -----
> 
> part/vimode/katevikeyparser.cpp 1c35ffa 
> 
> Diff: http://git.reviewboard.kde.org/r/114032/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michal Humpula
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/114032/">http://git.reviewboard.kde.org/r/114032/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since this patch has \
been rolled into https://git.reviewboard.kde.org/r/114033/, this can probably be \
closed, now.</pre>  <br />

<p>- Simon St James</p>

<br />
<p>On November 23rd, 2013, 5:50 p.m. UTC, Michal Humpula wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, Erlend Hamberg and Simon St James.</div>
<div>By Michal Humpula.</div>

<p style="color: grey;"><i>Updated Nov. 23, 2013, 5:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason (Qt, key config, keyboard, kernel, X, I don&#39;t \
know...) when I hit the Del key the QKeyEvent-&gt;text() contains some weirdly \
looking unicode character. So naturally the del key is not behaving for me properly. \
The patch makes sure, it does.

I have no idea how to write a test for this. Though I will be sending another patch \
with del keys extended with tests, so it might be just fine.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>part/vimode/katevikeyparser.cpp <span style="color: grey">(1c35ffa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/114032/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 