[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113917: Fix assert in ~QPersistentModelIndex
From: "Kevin Funk" <krf () gmx ! de>
Date: 2013-11-18 10:32:05
Message-ID: 20131118103205.10329.76945 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 18, 2013, 10:19 a.m., Milian Wolff wrote:
> > One small issue, otherwise looks good. Please get it into master and I'll test it \
> > there then. I assume you tested it for some weeks already, right? And the code \
> > completion tests in kate all pass as well?
Yes, tested it for one week, tests still pass. And the crash in bug 236948 is of \
course fixed.
However, I've just noticed that I might have introduced some performance regression \
with this patch. E.g. when broadening the completion filter, the UI seems to respond \
slower than before. I'll do some more investigation now before pushing this.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113917/#review43880
-----------------------------------------------------------
On Nov. 18, 2013, 9:39 a.m., Kevin Funk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113917/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2013, 9:39 a.m.)
>
>
> Review request for Kate and Milian Wolff.
>
>
> Bugs: 236948
> http://bugs.kde.org/show_bug.cgi?id=236948
>
>
> Repository: kate
>
>
> Description
> -------
>
> Fix assert in ~QPersistentModelIndex
>
> KateCompletionWidget may call QAIM::setCurrentIndex during a reset of
> the model, inside KateCompletionWidget::modelContentChanged(). At this
> point, model indices are invalid, but QAIM wasn't informed about it.
>
> The main problem is that KateCompletionModel doesn't use the
> (relatively) new {begin,end}ResetModel blocks to make persistent model indices
> invalid as soon as we start resetting the model. Instead reset() is used
> *after* we have reset the model. However, KateCompletionModel may emit
> contentGeometryChanged too early (before a reset()) and hence triggering
> QAIM::setCurrentIndex while QAIM is still referencing now invalid persistent model \
> indices.
> Other changes:
> Remove contentGeometryChanged. Instead, use layoutChanged() and
> modelReset() signals to react to model changes.
>
> BUG: 236948
> FIXED-IN: 4.13
>
>
> Diffs
> -----
>
> part/completion/katecompletionmodel.h 5fedbccc37cd49b7403827dafce15b498e99b160
> part/completion/katecompletionmodel.cpp 3fa8080ff95deb1e24327063ccd19dbb13ff49a8
> part/completion/katecompletionwidget.cpp 4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511
>
> Diff: http://git.reviewboard.kde.org/r/113917/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Funk
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113917/">http://git.reviewboard.kde.org/r/113917/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 18th, 2013, 10:19 a.m. UTC, <b>Milian \
Wolff</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">One small issue, otherwise looks good. Please get it into master and \
I'll test it there then. I assume you tested it for some weeks already, right? \
And the code completion tests in kate all pass as well?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, tested it for one \
week, tests still pass. And the crash in bug 236948 is of course fixed.
However, I've just noticed that I might have introduced some performance \
regression with this patch. E.g. when broadening the completion filter, the UI seems \
to respond slower than before. I'll do some more investigation now before pushing \
this.</pre> <br />
<p>- Kevin</p>
<br />
<p>On November 18th, 2013, 9:39 a.m. UTC, Kevin Funk wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Milian Wolff.</div>
<div>By Kevin Funk.</div>
<p style="color: grey;"><i>Updated Nov. 18, 2013, 9:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=236948">236948</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix assert in ~QPersistentModelIndex
KateCompletionWidget may call QAIM::setCurrentIndex during a reset of
the model, inside KateCompletionWidget::modelContentChanged(). At this
point, model indices are invalid, but QAIM wasn't informed about it.
The main problem is that KateCompletionModel doesn't use the
(relatively) new {begin,end}ResetModel blocks to make persistent model indices
invalid as soon as we start resetting the model. Instead reset() is used
*after* we have reset the model. However, KateCompletionModel may emit
contentGeometryChanged too early (before a reset()) and hence triggering
QAIM::setCurrentIndex while QAIM is still referencing now invalid persistent model \
indices.
Other changes:
Remove contentGeometryChanged. Instead, use layoutChanged() and
modelReset() signals to react to model changes.
BUG: 236948
FIXED-IN: 4.13</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/completion/katecompletionmodel.h <span style="color: \
grey">(5fedbccc37cd49b7403827dafce15b498e99b160)</span></li>
<li>part/completion/katecompletionmodel.cpp <span style="color: \
grey">(3fa8080ff95deb1e24327063ccd19dbb13ff49a8)</span></li>
<li>part/completion/katecompletionwidget.cpp <span style="color: \
grey">(4bb077e0973fd1eb9f1f5a7bb3e9bccae1a79511)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113917/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic