[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Fwd: Re: [kate] addons/kate/pate/src: Huh, another bunch of refactorings in pate has done.
From:       Milian Wolff <mail () milianw ! de>
Date:       2013-11-15 12:25:28
Message-ID: 1407636.6skIB4LK83 () milian-kdab2
[Download RAW message or body]


----------  Forwarded Message  ----------

Subject: Re: [kate] addons/kate/pate/src: Huh, another bunch of refactorings 
in pate has done.
Date: Friday 15 November 2013, 15:41:07
From: Alex Turbov <i.zaufi@gmail.com>
To: Milian Wolff <mail@milianw.de>

I'm sorry.
I pushed that accidentally. I had intention to restructure commits when
finished that refactoring...


On Fri, Nov 15, 2013 at 1:28 PM, Milian Wolff <mail@milianw.de> wrote:

> Everyone, please - write proper commit messages.
>
> This:
>
> On Friday 15 November 2013 01:34:00 Alex Turbov wrote:
> > Git commit ec20e08e37839b98fa315e5a55b527a2b5f26d32 by Alex Turbov.
> > Committed on 15/11/2013 at 01:17.
> > Pushed by turbov into branch 'master'.
> >
> > Huh, another bunch of refactorings in pate has done.
>
> Is _not_ OK. A commit message should be structured as such:
>
> WHAT
>
> HOW
> and
> WHY
> and
> WHERE
> ...
>
> I.e.:
>
> Refactor Pate for $something (e.g. code cleanup? performance?)
>
> This does X, Y and Z resulting in Foo, Bar and Baz. This is better because
> of
> ..., see also ...
>
> Generally, commit messages such as the above make maintenance really hard,
> when you try to fix a bug years down the route and git annotate just gives
> you
> a "Huh" as commit message...
>
> Bye
> --
> Milian Wolff
> mail@milianw.de
> http://milianw.de
>
-----------------------------------------
-- 
Milian Wolff
mail@milianw.de
http://milianw.de
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]