[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Review Request 113859: Single characters made QChar instead of QString
From: "Harsh Kumar" <harsh1kumar () gmail ! com>
Date: 2013-11-14 15:32:20
Message-ID: 20131114153220.480.28492 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113859/
-----------------------------------------------------------
Review request for Kate.
Repository: kate
Description
-------
Making single characters as QChar when they are added to a QString.
Adding single characters to a QString is faster if the characters are QChars and not \
QStrings.
Same holds for arguments to QString::startsWith(), QString::endsWith(), \
QString::remove() and QString::section() Changes made to in these function calls as \
well
Diffs
-----
part/vimode/kateviglobal.cpp 4f06796
part/vimode/kateviinsertmode.cpp a520785
part/vimode/katevinormalmode.cpp e8af968
tests/script_test_base.cpp 18b3aa9
tests/vimode_test.cpp ed94c0c
addons/kate/close-except-like/close_except_plugin.cpp 1cc5b59
addons/kate/gdbplugin/debugview.cpp 7afe0ec
addons/kate/kate-ctags/kate_ctags_plugin.cpp f145c44
addons/kate/kate-ctags/kate_ctags_view.cpp 7d66461
addons/kate/katesql/schemawidget.cpp 68a8ffe
addons/kate/project/kateprojectworker.cpp e23ae6e
addons/kate/search/plugin_search.cpp cd1ed08
addons/kate/symbolviewer/php_parser.cpp 36e8ded
addons/kate/textfilter/plugin_katetextfilter.cpp 5a00fce
addons/kate/xmltools/plugin_katexmltools.cpp 793e707
ktexteditor/templateinterface.cpp 51f1e38
Diff: http://git.reviewboard.kde.org/r/113859/diff/
Testing
-------
Compiles & runs
Thanks,
Harsh Kumar
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113859/">http://git.reviewboard.kde.org/r/113859/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Harsh Kumar.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Making single characters as QChar when they are added to a QString. \
Adding single characters to a QString is faster if the characters are QChars and not \
QStrings.
Same holds for arguments to QString::startsWith(), QString::endsWith(), \
QString::remove() and QString::section() Changes made to in these function calls as \
well</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles & runs</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/vimode/kateviglobal.cpp <span style="color: grey">(4f06796)</span></li>
<li>part/vimode/kateviinsertmode.cpp <span style="color: grey">(a520785)</span></li>
<li>part/vimode/katevinormalmode.cpp <span style="color: grey">(e8af968)</span></li>
<li>tests/script_test_base.cpp <span style="color: grey">(18b3aa9)</span></li>
<li>tests/vimode_test.cpp <span style="color: grey">(ed94c0c)</span></li>
<li>addons/kate/close-except-like/close_except_plugin.cpp <span style="color: \
grey">(1cc5b59)</span></li>
<li>addons/kate/gdbplugin/debugview.cpp <span style="color: \
grey">(7afe0ec)</span></li>
<li>addons/kate/kate-ctags/kate_ctags_plugin.cpp <span style="color: \
grey">(f145c44)</span></li>
<li>addons/kate/kate-ctags/kate_ctags_view.cpp <span style="color: \
grey">(7d66461)</span></li>
<li>addons/kate/katesql/schemawidget.cpp <span style="color: \
grey">(68a8ffe)</span></li>
<li>addons/kate/project/kateprojectworker.cpp <span style="color: \
grey">(e23ae6e)</span></li>
<li>addons/kate/search/plugin_search.cpp <span style="color: \
grey">(cd1ed08)</span></li>
<li>addons/kate/symbolviewer/php_parser.cpp <span style="color: \
grey">(36e8ded)</span></li>
<li>addons/kate/textfilter/plugin_katetextfilter.cpp <span style="color: \
grey">(5a00fce)</span></li>
<li>addons/kate/xmltools/plugin_katexmltools.cpp <span style="color: \
grey">(793e707)</span></li>
<li>ktexteditor/templateinterface.cpp <span style="color: \
grey">(51f1e38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113859/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic