[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Re: Review Request 113790: added jshint and restructured jsutils
From: J._Pablo_Martín_Cobos <goinnn () gmail ! com>
Date: 2013-11-12 11:02:23
Message-ID: CALNyWLFmAJin=dC4zOnWaK6Z05YyjfCUd-xTdwrMVJJihkc6pw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
2013/11/12 Dominik Haumann <dhaumann@kde.org>
> On Tuesday, November 12, 2013 08:41:15 Phil Schaf wrote:
> > > On Nov. 11, 2013, 1:14 p.m., Pablo MartĂn wrote:
> > > > Please could you tell me if is there some settings to desactive the
> > > > jslint when save?
> > > >
> > > > Something like in the old version?
> > > >
> > > >
> https://projects.kde.org/projects/kde/applications/kate/repository/revis
> > > >
> ions/master/entry/addons/kate/pate/src/plugins/js_utils/jslint.py#L49>
> > > Pablo MartĂn wrote:
> > > Please could you tell me if is there some settings to deactivate
> the
> > > jslint when save a file?>
> > > Phil Schaf wrote:
> > > i didn't remove that setting. i just split the lint function in
> 2:
> > >
> > > 1. the version that gets called on save, lint_on_save (line 102),
> > > which does those checks (e.g. SETTING_LINT_ON_SAVE.lookup()) and
> then
> > > invokes the linting on the saved document 2. the version that gets
> > > invoked by an action, lint_js_action (line 97), which naturally
> > > doesn't check for that setting (you should be able to manually
> lint
> > > the document whenever you want)>
> > > Pablo MartĂn wrote:
> > > An end user could you disable this feature?
> > >
> > > I think that you remove it, but I don't know, it's possible that I
> am
> > > wrong
> > >
> > > Imagine that you are editing a js with a lot of errors... it's
> > > possible that you want disable this feature. Or It is possible that
> > > you want use js_utils plugin but you dislike jslint feature.>
> > > Phil Schaf wrote:
> > > what's not to understand of "i didn't remove that settingâ€
> > >
> > > here's the UI:
> https://git.reviewboard.kde.org/r/113790/diff/#9.21
> > > and here's the code:
> > > https://git.reviewboard.kde.org/r/113790/diff/#5.20
> > > (SETTING_LINT_ON_SAVE)
> > >
> > > Phil Schaf wrote:
> > > http://i.imgur.com/koz923j.png
> > >
> > > Pablo MartĂn wrote:
> > > Philp please, you are very offensive with me.
> > >
> > > Only I wanted to be sure, I didn't understand the implications of
> this
> > > sentence: "removed necessity ro restart kate after changing
> settings"
> > "ro†should have been "to†, but otherwise it's easy to
> understand:
> after
> > changing a setting, js_utils used to need a restart (as the value of the
> > setting is put into a variable at the time the plugin was loaded)
> >
> > as it is now, each setting is looked up at the time its value is needed,
> > i.e. when the code needs to know the setting's value.
> >
> > ---
> >
> > i'm offensive because your criticism is based on misunderstandings,
> and i
> > don't like to spend my time explaining how i meant things. if i
> didn't
> > express myself properly, OK, but normally people understand what i write.
> > the only one constantly having problems with it is you.
> >
> > i'm sorry that i was so harsh, because i now know now that only your
> skills
> > in english prevent you from understanding me. but it' still annoying to
> > have to rephrase things until you get it.
> >
> > so is there a solution to that problem? i think yes: you'll have to
> invest
> > more time than developers who understand english better. you'll have to
> > create a branch, apply the diff, and test if a problem is really there
> > before you just assume it is and create an issue here.
>
> So let's sum up: Pablos concerns for now are not an issue, since the
> available
> funcionality still works. It's interesting to see how these
> misunderstandings
> evolve into such heated discussions. The good thing is: We all try to find
> a
> good solution, and that's why it's certainly good to have this discussion
> :-)
>
>
Thanks Dominik. I think that it is a good thing if I ask for the evolution
of a plugin that I coded in the past.
I always try to be very very polite, and I've only had problems with
Phil... but I think that the insults are unacceptable
> At this point, can we agree to proceed with a review of the review request?
> My guts tell me this is a good patch, but I at the current time lack the
> insights to do a proper review. So a bit more feedback would be nice.
>
> Besides that, I think this patch should go in as soon as possible: If
> something does not work, I'm sure it still can be fixed.
>
> Imo, this is a good way to go forward. Right?
>
> Thanks ;)
> Dominik
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
>
[Attachment #5 (text/html)]
<div dir="ltr">2013/11/12 Dominik Haumann <span dir="ltr"><<a \
href="mailto:dhaumann@kde.org" \
target="_blank">dhaumann@kde.org</a>></span><br><div class="gmail_extra"><div \
class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
On Tuesday, November 12, 2013 08:41:15 Phil Schaf wrote:<br>
<div class="im">> > On Nov. 11, 2013, 1:14 p.m., Pablo MartĂn wrote:<br>
> > > Please could you tell me if is there some settings to desactive \
the<br> > > > jslint when save?<br>
> > ><br>
> > > Something like in the old version?<br>
> > ><br>
> > > <a href="https://projects.kde.org/projects/kde/applications/kate/repository/revis" \
target="_blank">https://projects.kde.org/projects/kde/applications/kate/repository/revis</a><br>
> > > ions/master/entry/addons/kate/pate/src/plugins/js_utils/jslint.py#L49><br>
</div><div class="im">> > Pablo MartĂn wrote:<br>
> > Please could you tell me if is there some settings to deactivate \
the<br> > > jslint when save a file?><br>
</div>> > Phil Schaf wrote:<br>
> > i didn't remove that setting. i just split the lint function in 2:<br>
<div class="im">> ><br>
> > 1. the version that gets called on save, lint_on_save (line 102),<br>
> > which does those checks (e.g. SETTING_LINT_ON_SAVE.lookup()) and \
then<br> > > invokes the linting on the saved document 2. the version that \
gets<br> > > invoked by an action, lint_js_action (line 97), which \
naturally<br> </div>> > doesn't check for that setting (you should be able \
to manually lint<br> <div class="im">> > the document whenever you \
want)><br> </div><div class="im">> > Pablo MartĂn wrote:<br>
> > An end user could you disable this feature?<br>
> ><br>
> > I think that you remove it, but I don't know, it's possible \
that I am<br> > > wrong<br>
> ><br>
> > Imagine that you are editing a js with a lot of errors... it's<br>
> > possible that you want disable this feature. Or It is possible that<br>
> > you want use js_utils plugin but you dislike jslint feature.><br>
</div>> > Phil Schaf wrote:<br>
> > what's not to understand of "i didn't remove that settingâ€<br>
> ><br>
> > here's the UI: <a \
href="https://git.reviewboard.kde.org/r/113790/diff/#9.21" \
target="_blank">https://git.reviewboard.kde.org/r/113790/diff/#9.21</a><br> > > \
and here's the code:<br> > > <a \
href="https://git.reviewboard.kde.org/r/113790/diff/#5.20" \
target="_blank">https://git.reviewboard.kde.org/r/113790/diff/#5.20</a><br> > > \
(SETTING_LINT_ON_SAVE)<br> > ><br>
<div class="im">> > Phil Schaf wrote:<br>
> > <a href="http://i.imgur.com/koz923j.png" \
target="_blank">http://i.imgur.com/koz923j.png</a><br> > ><br>
</div><div class="im">> > Pablo MartĂn wrote:<br>
> > Philp please, you are very offensive with me.<br>
> ><br>
> > Only I wanted to be sure, I didn't understand the implications of \
this<br> > > sentence: "removed necessity ro restart kate after \
changing settings"<br> </div>> "ro†should have been "to†, but otherwise \
it's easy to understand:<br> <div class="im">after<br>
> changing a setting, js_utils used to need a restart (as the value of the<br>
> setting is put into a variable at the time the plugin was loaded)<br>
><br>
> as it is now, each setting is looked up at the time its value is needed,<br>
</div>> i.e. when the code needs to know the setting's value.<br>
><br>
> ---<br>
><br>
> i'm offensive because your criticism is based on misunderstandings, and i<br>
> don't like to spend my time explaining how i meant things. if i didn't<br>
<div class="im">> express myself properly, OK, but normally people understand what \
i write.<br> > the only one constantly having problems with it is you.<br>
><br>
</div>> i'm sorry that i was so harsh, because i now know now that only your<br>
skills<br>
> in english prevent you from understanding me. but it' still annoying to<br>
<div class="im">> have to rephrase things until you get it.<br>
><br>
</div>> so is there a solution to that problem? i think yes: you'll have to \
invest<br> > more time than developers who understand english better. you'll have \
to<br> <div class="im">> create a branch, apply the diff, and test if a problem is \
really there<br> > before you just assume it is and create an issue here.<br>
<br>
</div>So let's sum up: Pablos concerns for now are not an issue, since the \
available<br> funcionality still works. It's interesting to see how these \
misunderstandings<br> evolve into such heated discussions. The good thing is: We all \
try to find a<br> good solution, and that's why it's certainly good to have \
this discussion :-)<br> <br></blockquote><div><br></div><div>Thanks Dominik. I think \
that it is a good thing if I ask for the evolution of a plugin that I coded in the \
past. </div><div><br></div><div>I always try to be very very <span \
style="font-size:13px;color:rgb(0,0,0);font-family:arial,sans-serif;white-space:nowrap">polite, \
and </span><font color="#000000" face="arial, sans-serif"><span \
style="white-space:nowrap">I've only had problems with Phil... but I think that \
the insults are unacceptable</span></font></div> <div> </div><blockquote \
class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
At this point, can we agree to proceed with a review of the review request?<br>
My guts tell me this is a good patch, but I at the current time lack the<br>
insights to do a proper review. So a bit more feedback would be nice.<br>
<br>
Besides that, I think this patch should go in as soon as possible: If<br>
something does not work, I'm sure it still can be fixed.<br>
<br>
Imo, this is a good way to go forward. Right?<br>
<br>
Thanks ;)<br>
Dominik<br>
_______________________________________________<br>
KWrite-Devel mailing list<br>
<a href="mailto:KWrite-Devel@kde.org">KWrite-Devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kwrite-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kwrite-devel</a><br> \
</blockquote></div><br></div></div>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic