[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113720: Python plugins refactored
From: "Philipp A." <flying-sheep () web ! de>
Date: 2013-11-11 18:41:24
Message-ID: CAN8d9gkZuz+0Uw3TPzOwS38WyJYCdcEcHTEJFAuf7Ht8PCnX-g () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
i've got a problem now:
$ cmake .. -DCMAKE_INSTALL_PREFIX=~/Dev/KDE -DBUILD_KTEXTEDITOR=1
-DINSTALL_PYTHON_FILES_IN_PYTHON_PREFIX=OFF
$ make
…
[ 77%] Built target katepateplugin_automoc
[ 77%] Building CXX object
addons/kate/pate/src/CMakeFiles/katepateplugin.dir/katepateplugin_automoc.o
In file included from /usr/include/python3.3m/pytime.h:6:0,
from /usr/include/python3.3m/Python.h:65,
from
/home/phil/Dev/KDE/kate/build/addons/kate/pate/src/../../../../../addons/kate/pate/src/engine.h:26,
from
/home/phil/Dev/KDE/kate/build/addons/kate/pate/src/moc_engine.cpp:9,
from
/home/phil/Dev/KDE/kate/build/addons/kate/pate/src/katepateplugin_automoc.cpp:4:
/usr/include/python3.3m/object.h:432:23: Fehler: expected unqualified-id
before »; « token
PyType_Slot *slots; /* terminated by slot==0. */
2013/11/11 Alex Turbov <i.zaufi@gmail.com>
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113720/
> This change has been marked as submitted.
> Review request for Kate and Shaheed Haque.
> By Alex Turbov.
>
> *Updated Nov. 11, 2013, 5:29 p.m.*
> *Repository: * kate
> Description
>
> Search installed Python plugins via trader.
> Introduce `Kate/PythonPlugin` service type.
> Make plugins management look-n-feel as C++ plugins.
> Enabled plugins now are per session (stored under "Enabled Plugins" key of the pate \
> config group), so it is possible to have different plugins in different sessions \
> (just like C++ plugins).
> Sample .desktop file:
>
> [Desktop Entry]
> Type=Service
> ServiceTypes=Kate/PythonPlugin
> X-KDE-Library=cmake_utils/cmake_utils.py
> Name=CMake Utilities
> Comment=Code completer, cache and help browser
> X-Python-2-Compatible=false
> X-Python-3-Compatible=true
>
> The patch contains .desktop files only for plugins I wrote (and use) myself. Other \
> plugins still need .desktop files (I don't know exactly which Python they are \
> require)
> Diffs
>
> - addons/kate/pate/src/utilities.cpp (3ed19d6)
> - addons/kate/pate/src/utilities.h (d88af0f)
> - addons/kate/pate/src/plugins/format.desktop (PRE-CREATION)
> - addons/kate/pate/src/plugins/expand.desktop (PRE-CREATION)
> - addons/kate/pate/src/plugins/commentar.desktop (PRE-CREATION)
> - addons/kate/pate/src/plugins/color_tools.desktop (PRE-CREATION)
> - addons/kate/pate/src/plugins/cmake_utils/cmake_utils.desktop
> (PRE-CREATION)
> - addons/kate/pate/src/plugins/block.desktop (PRE-CREATION)
> - addons/kate/pate/src/plugin.cpp (85c84a3)
> - addons/kate/pate/src/plugin.h (77369c6)
> - addons/kate/pate/src/manager.ui (82213ee)
> - addons/kate/pate/src/katepythonplugin.desktop (PRE-CREATION)
> - addons/kate/pate/src/engine.cpp (5484473)
> - addons/kate/pate/src/engine.h (6c70ab9)
> - addons/kate/pate/src/CMakeLists.txt (78bbdc0)
>
> View Diff <http://git.reviewboard.kde.org/r/113720/diff/>
> File Attachments
>
> - Python Plugins Management<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/08/f711a85f-34f7-4b2c-99d2-f1c375fcf88f__python-plugins-redesigned.png>
>
> - the next (intermediate) commit after the \
> original<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0087837c-71aa-4b54-988b-5ce0c219c1b6__0001-few-more-.desktop-files.patch>
>
> - The next revision after first \
> review<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/3d91861b-2d2c- \
> 45e0-8b26-ec33d9958dd0__0002-Add-separate-CMakeLists.txt-for-pate-src-plugins.patch>
>
> - Single patch for everything! (made against master w/ squashed
> commits)<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/2bcd97ab-ec4 \
> c-4bb0-856a-de41e28ec28d__0001-Python-plugins-refactored-as-a-single-patch.patch>
>
> - Broken plugin case<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0fd371ca-0e59-4f84-a742-cb3ed326a82a__broken-plugin.png>
>
> - One more patch to apply after \
> all<http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/a0836b05-1f9a-472 \
> c-9fd5-be065b807903__0001-Introduce-per-session-configuration-data-for-Python-.patch>
>
>
> _______________________________________________
> KWrite-Devel mailing list
> KWrite-Devel@kde.org
> https://mail.kde.org/mailman/listinfo/kwrite-devel
>
>
[Attachment #5 (text/html)]
<div dir="ltr"><div>i've got a problem now:<br><br>$ cmake .. \
-DCMAKE_INSTALL_PREFIX=~/Dev/KDE -DBUILD_KTEXTEDITOR=1 \
-DINSTALL_PYTHON_FILES_IN_PYTHON_PREFIX=OFF<br></div>$ make<br><div>…<br>[ 77%] \
Built target katepateplugin_automoc<br> [ 77%] Building CXX object \
addons/kate/pate/src/CMakeFiles/katepateplugin.dir/katepateplugin_automoc.o<br>In \
file included from /usr/include/python3.3m/pytime.h:6:0,<br> \
from /usr/include/python3.3m/Python.h:65,<br> from \
/home/phil/Dev/KDE/kate/build/addons/kate/pate/src/../../../../../addons/kate/pate/src/engine.h:26,<br> \
from /home/phil/Dev/KDE/kate/build/addons/kate/pate/src/moc_engine.cpp:9,<br> \
from /home/phil/Dev/KDE/kate/build/addons/kate/pate/src/katepateplugin_automoc.cpp:4:<br>
/usr/include/python3.3m/object.h:432:23: Fehler: expected unqualified-id before »; « \
token<br> PyType_Slot *slots; /* terminated by slot==0. \
*/<br><br><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"> \
2013/11/11 Alex Turbov <span dir="ltr"><<a href="mailto:i.zaufi@gmail.com" \
target="_blank">i.zaufi@gmail.com</a>></span><br><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113720/" \
target="_blank">http://git.reviewboard.kde.org/r/113720/</a> </td>
</tr>
</tbody></table>
<br>
</div><table style="border:1px gray solid" bgcolor="#e0e0e0" cellpadding="8" \
width="100%"> <tbody><tr>
<td>
<h1 style="margin-right:0.2em;padding:0;font-size:10pt">This change has been \
marked as submitted.</h1> </td>
</tr>
</tbody></table>
<br>
<table style="background-image:url('');background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%"> \
<tbody><tr> <td><div class="im">
<div>Review request for Kate and Shaheed Haque.</div>
<div>By Alex Turbov.</div>
</div><p style="color:grey"><i>Updated Nov. 11, 2013, 5:29 p.m.</i></p><div><div \
class="h5">
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
kate
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Search \
installed Python plugins via trader. Introduce `Kate/PythonPlugin` service type.
Make plugins management look-n-feel as C++ plugins.
Enabled plugins now are per session (stored under "Enabled Plugins" key of \
the pate config group), so it is possible to have different plugins in different \
sessions (just like C++ plugins).
Sample .desktop file:
[Desktop Entry]
Type=Service
ServiceTypes=Kate/PythonPlugin
X-KDE-Library=cmake_utils/cmake_utils.py
Name=CMake Utilities
Comment=Code completer, cache and help browser
X-Python-2-Compatible=false
X-Python-3-Compatible=true
The patch contains .desktop files only for plugins I wrote (and use) myself. Other \
plugins still need .desktop files (I don't know exactly which Python they are \
require)</pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>addons/kate/pate/src/utilities.cpp <span \
style="color:grey">(3ed19d6)</span></li>
<li>addons/kate/pate/src/utilities.h <span style="color:grey">(d88af0f)</span></li>
<li>addons/kate/pate/src/plugins/format.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/expand.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/commentar.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/color_tools.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/cmake_utils/cmake_utils.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugins/block.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/plugin.cpp <span style="color:grey">(85c84a3)</span></li>
<li>addons/kate/pate/src/plugin.h <span style="color:grey">(77369c6)</span></li>
<li>addons/kate/pate/src/manager.ui <span style="color:grey">(82213ee)</span></li>
<li>addons/kate/pate/src/katepythonplugin.desktop <span \
style="color:grey">(PRE-CREATION)</span></li>
<li>addons/kate/pate/src/engine.cpp <span style="color:grey">(5484473)</span></li>
<li>addons/kate/pate/src/engine.h <span style="color:grey">(6c70ab9)</span></li>
<li>addons/kate/pate/src/CMakeLists.txt <span \
style="color:grey">(78bbdc0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113720/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">File Attachments </h1>
</div></div><div class="im"><ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/08/f711a85f-34f7-4b2c-99d2-f1c375fcf88f__python-plugins-redesigned.png" \
target="_blank">Python Plugins Management</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0087837c-71aa-4b54-988b-5ce0c219c1b6__0001-few-more-.desktop-files.patch" \
target="_blank">the next (intermediate) commit after the original</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/3d91861b- \
2d2c-45e0-8b26-ec33d9958dd0__0002-Add-separate-CMakeLists.txt-for-pate-src-plugins.patch" \
target="_blank">The next revision after first review</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/2bcd97ab- \
ec4c-4bb0-856a-de41e28ec28d__0001-Python-plugins-refactored-as-a-single-patch.patch" \
target="_blank">Single patch for everything! (made against master w/ squashed \
commits)</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0fd371ca-0e59-4f84-a742-cb3ed326a82a__broken-plugin.png" \
target="_blank">Broken plugin case</a></li>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/a0836b05- \
1f9a-472c-9fd5-be065b807903__0001-Introduce-per-session-configuration-data-for-Python-.patch" \
target="_blank">One more patch to apply after all</a></li>
</ul>
</div></td>
</tr>
</tbody></table>
</div>
</div>
<br>_______________________________________________<br>
KWrite-Devel mailing list<br>
<a href="mailto:KWrite-Devel@kde.org">KWrite-Devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kwrite-devel" \
target="_blank">https://mail.kde.org/mailman/listinfo/kwrite-devel</a><br> \
<br></blockquote></div><br></div>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic