From kwrite-devel Mon Nov 11 17:29:56 2013 From: "Alex Turbov" Date: Mon, 11 Nov 2013 17:29:56 +0000 To: kwrite-devel Subject: Re: Review Request 113720: Python plugins refactored Message-Id: <20131111172956.15361.98382 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138419101823100 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8532616800173877590==" --===============8532616800173877590== Content-Type: multipart/alternative; boundary="===============0029057497655962526==" --===============0029057497655962526== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113720/ ----------------------------------------------------------- (Updated Nov. 11, 2013, 5:29 p.m.) Status ------ This change has been marked as submitted. Review request for Kate and Shaheed Haque. Repository: kate Description ------- Search installed Python plugins via trader. Introduce `Kate/PythonPlugin` service type. Make plugins management look-n-feel as C++ plugins. Enabled plugins now are per session (stored under "Enabled Plugins" key of the pate config group), so it is possible to have different plugins in different sessions (just like C++ plugins). Sample .desktop file: [Desktop Entry] Type=Service ServiceTypes=Kate/PythonPlugin X-KDE-Library=cmake_utils/cmake_utils.py Name=CMake Utilities Comment=Code completer, cache and help browser X-Python-2-Compatible=false X-Python-3-Compatible=true The patch contains .desktop files only for plugins I wrote (and use) myself. Other plugins still need .desktop files (I don't know exactly which Python they are require) Diffs ----- addons/kate/pate/src/utilities.cpp 3ed19d6 addons/kate/pate/src/utilities.h d88af0f addons/kate/pate/src/plugins/format.desktop PRE-CREATION addons/kate/pate/src/plugins/expand.desktop PRE-CREATION addons/kate/pate/src/plugins/commentar.desktop PRE-CREATION addons/kate/pate/src/plugins/color_tools.desktop PRE-CREATION addons/kate/pate/src/plugins/cmake_utils/cmake_utils.desktop PRE-CREATION addons/kate/pate/src/plugins/block.desktop PRE-CREATION addons/kate/pate/src/plugin.cpp 85c84a3 addons/kate/pate/src/plugin.h 77369c6 addons/kate/pate/src/manager.ui 82213ee addons/kate/pate/src/katepythonplugin.desktop PRE-CREATION addons/kate/pate/src/engine.cpp 5484473 addons/kate/pate/src/engine.h 6c70ab9 addons/kate/pate/src/CMakeLists.txt 78bbdc0 Diff: http://git.reviewboard.kde.org/r/113720/diff/ Testing ------- File Attachments ---------------- Python Plugins Management http://git.reviewboard.kde.org/media/uploaded/files/2013/11/08/f711a85f-34f7-4b2c-99d2-f1c375fcf88f__python-plugins-redesigned.png the next (intermediate) commit after the original http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0087837c-71aa-4b54-988b-5ce0c219c1b6__0001-few-more-.desktop-files.patch The next revision after first review http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/3d91861b-2d2c-45e0-8b26-ec33d9958dd0__0002-Add-separate-CMakeLists.txt-for-pate-src-plugins.patch Single patch for everything! (made against master w/ squashed commits) http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/2bcd97ab-ec4c-4bb0-856a-de41e28ec28d__0001-Python-plugins-refactored-as-a-single-patch.patch Broken plugin case http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/0fd371ca-0e59-4f84-a742-cb3ed326a82a__broken-plugin.png One more patch to apply after all http://git.reviewboard.kde.org/media/uploaded/files/2013/11/11/a0836b05-1f9a-472c-9fd5-be065b807903__0001-Introduce-per-session-configuration-data-for-Python-.patch Thanks, Alex Turbov --===============0029057497655962526== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113720/

This change has been marked as submitted.

Review request for Kate and Shaheed Haque.

By Alex Turbov.

Updated Nov. 11, 2013, 5:29 p.m.

Repository: kate

Description

Search installed Python plugins via trader. 
Introduce `Kate/PythonPlugin` service type. 
Make plugins management look-n-feel as C++ plugins.
Enabled plugins now are per session (stored under "Enabled Plugins" key of the pate config group), so it is possible to have different plugins in different sessions (just like C++ plugins).

Sample .desktop file:

[Desktop Entry]
Type=Service
ServiceTypes=Kate/PythonPlugin
X-KDE-Library=cmake_utils/cmake_utils.py
Name=CMake Utilities
Comment=Code completer, cache and help browser
X-Python-2-Compatible=false
X-Python-3-Compatible=true

The patch contains .desktop files only for plugins I wrote (and use) myself. Other plugins still need .desktop files (I don't know exactly which Python they are require)

Diffs

addons/kate/pate/src/utilities.cpp (3ed19d6)
addons/kate/pate/src/utilities.h (d88af0f)
addons/kate/pate/src/plugins/format.desktop (PRE-CREATION)
addons/kate/pate/src/plugins/expand.desktop (PRE-CREATION)
addons/kate/pate/src/plugins/commentar.desktop (PRE-CREATION)
addons/kate/pate/src/plugins/color_tools.desktop (PRE-CREATION)
addons/kate/pate/src/plugins/cmake_utils/cmake_utils.desktop (PRE-CREATION)
addons/kate/pate/src/plugins/block.desktop (PRE-CREATION)
addons/kate/pate/src/plugin.cpp (85c84a3)
addons/kate/pate/src/plugin.h (77369c6)
addons/kate/pate/src/manager.ui (82213ee)
addons/kate/pate/src/katepythonplugin.desktop (PRE-CREATION)
addons/kate/pate/src/engine.cpp (5484473)
addons/kate/pate/src/engine.h (6c70ab9)
addons/kate/pate/src/CMakeLists.txt (78bbdc0)

File Attachments

--===============0029057497655962526==-- --===============8532616800173877590== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============8532616800173877590==--