This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113720/

This review has been submitted with commit 0f7eb94119a4e7b1085a4f6e95ecacf10bab6787 by Alex Turbov to branch master.

- Commit Hook


On November 11th, 2013, 7:20 a.m. UTC, Alex Turbov wrote:

Review request for Kate and Shaheed Haque.
By Alex Turbov.

Updated Nov. 11, 2013, 7:20 a.m.

Repository: kate

Description

Search installed Python plugins via trader. 
Introduce `Kate/PythonPlugin` service type. 
Make plugins management look-n-feel as C++ plugins.
Enabled plugins now are per session (stored under "Enabled Plugins" key of the pate config group), so it is possible to have different plugins in different sessions (just like C++ plugins).

Sample .desktop file:

[Desktop Entry]
Type=Service
ServiceTypes=Kate/PythonPlugin
X-KDE-Library=cmake_utils/cmake_utils.py
Name=CMake Utilities
Comment=Code completer, cache and help browser
X-Python-2-Compatible=false
X-Python-3-Compatible=true

The patch contains .desktop files only for plugins I wrote (and use) myself. Other plugins still need .desktop files (I don't know exactly which Python they are require)

Diffs

  • addons/kate/pate/src/utilities.cpp (3ed19d6)
  • addons/kate/pate/src/utilities.h (d88af0f)
  • addons/kate/pate/src/plugins/format.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugins/expand.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugins/commentar.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugins/color_tools.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugins/cmake_utils/cmake_utils.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugins/block.desktop (PRE-CREATION)
  • addons/kate/pate/src/plugin.cpp (85c84a3)
  • addons/kate/pate/src/plugin.h (77369c6)
  • addons/kate/pate/src/manager.ui (82213ee)
  • addons/kate/pate/src/katepythonplugin.desktop (PRE-CREATION)
  • addons/kate/pate/src/engine.cpp (5484473)
  • addons/kate/pate/src/engine.h (6c70ab9)
  • addons/kate/pate/src/CMakeLists.txt (78bbdc0)

View Diff

File Attachments