From kwrite-devel Mon Nov 11 12:38:32 2013 From: "Phil Schaf" Date: Mon, 11 Nov 2013 12:38:32 +0000 To: kwrite-devel Subject: Re: Review Request 113790: added jshint and restructured jsutils Message-Id: <20131111123832.13286.23503 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kwrite-devel&m=138419007220421 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1306389909687018000==" --===============1306389909687018000== Content-Type: multipart/alternative; boundary="===============4052940591498130812==" --===============4052940591498130812== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113790/ ----------------------------------------------------------- (Updated Nov. 11, 2013, 12:38 p.m.) Review request for Kate. Summary (updated) ----------------- added jshint and restructured jsutils Repository: kate Description ------- restructured JSUtils and added an option to use JSHint instead of the opinionated JSLint. removed dependency (we don’t need a clumsy JS wrapper using system calls if Qt already has a JS runtime) removed necessity ro restart kate after changing settings. i created many useful utilities in the process which simplify settings and JS. maybe we could add them to libkatepate? Diffs ----- addons/kate/pate/src/CMakeLists.txt 78bbdc0 addons/kate/pate/src/plugins/js_utils/fulljslint.js PRE-CREATION addons/kate/pate/src/plugins/js_utils/js_autocomplete.py 40b1523 addons/kate/pate/src/plugins/js_utils/js_engine.py PRE-CREATION addons/kate/pate/src/plugins/js_utils/js_lint.py PRE-CREATION addons/kate/pate/src/plugins/js_utils/js_settings.py 4272372 addons/kate/pate/src/plugins/js_utils/js_snippets.py d684b25 addons/kate/pate/src/plugins/js_utils/js_utils.py ee879a0 addons/kate/pate/src/plugins/js_utils/js_utils.ui 6fd8b20 addons/kate/pate/src/plugins/js_utils/jshint.js PRE-CREATION addons/kate/pate/src/plugins/js_utils/jslint.py 03fea05 addons/kate/pate/src/plugins/js_utils/json_pretty.py 135e72d Diff: http://git.reviewboard.kde.org/r/113790/diff/ Testing ------- Thanks, Phil Schaf --===============4052940591498130812== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113790/

Review request for Kate.
By Phil Schaf.

Updated Nov. 11, 2013, 12:38 p.m.

Summary (updated)

added jshint and restructured jsutils
Repository: kate

Description 

restructured JSUtils and added an option to use JSHint instead of the opinionated JSLint.

removed dependency (we don’t need a clumsy JS wrapper using system calls if Qt already has a JS runtime)

removed necessity ro restart kate after changing settings.

i created many useful utilities in the process which simplify settings and JS. maybe we could add them to libkatepate?

Diffs

  • addons/kate/pate/src/CMakeLists.txt (78bbdc0)
  • addons/kate/pate/src/plugins/js_utils/fulljslint.js (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_autocomplete.py (40b1523)
  • addons/kate/pate/src/plugins/js_utils/js_engine.py (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_lint.py (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/js_settings.py (4272372)
  • addons/kate/pate/src/plugins/js_utils/js_snippets.py (d684b25)
  • addons/kate/pate/src/plugins/js_utils/js_utils.py (ee879a0)
  • addons/kate/pate/src/plugins/js_utils/js_utils.ui (6fd8b20)
  • addons/kate/pate/src/plugins/js_utils/jshint.js (PRE-CREATION)
  • addons/kate/pate/src/plugins/js_utils/jslint.py (03fea05)
  • addons/kate/pate/src/plugins/js_utils/json_pretty.py (135e72d)

View Diff
--===============4052940591498130812==-- --===============1306389909687018000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ KWrite-Devel mailing list KWrite-Devel@kde.org https://mail.kde.org/mailman/listinfo/kwrite-devel --===============1306389909687018000==--