On November 10th, 2013, 11:22 a.m. UTC, Dominik Haumann wrote:

addons/kate/pate/src/engine.h (Diff revision 1)
		46	KService::Ptr m_srv;

Since this is a public struct, we usually omit the m_ prefix in this case. And:
- srv -> service
- module_file -> moduleFile
- error_reason -> errorReason

Going to make it as a class w/ accessors... Only Engine can make instances of it, everybody else can only read it...

On November 10th, 2013, 11:22 a.m. UTC, Dominik Haumann wrote:

addons/kate/pate/src/engine.cpp (Diff revision 1)
PyMODINIT_FUNC PATE_INIT(void)
181	s_self = new Pate::Engine(qApp);	110	s_self = new Pate::Engine();

Now that the Pate::Engine() has no parent, who deletes finally? Maybe I'm missing a delete call in the destructor of the Pate plugin or somehwere else?

Going to make it as a data member of Plugin class instead of singleton.

- Alex

On November 8th, 2013, 6:09 a.m. UTC, Alex Turbov wrote:

Search installed Python plugins via trader. 
Introduce `Kate/PythonPlugin` service type. 
Make plugins management look-n-feel as C++ plugins.
Enabled plugins now are per session (stored under "Enabled Plugins" key of the pate config group), so it is possible to have different plugins in different sessions (just like C++ plugins).

Sample .desktop file:

[Desktop Entry]
Type=Service
ServiceTypes=Kate/PythonPlugin
X-KDE-Library=cmake_utils/cmake_utils.py
Name=CMake Utilities
Comment=Code completer, cache and help browser
X-Python-2-Compatible=false
X-Python-3-Compatible=true

The patch contains .desktop files only for plugins I wrote (and use) myself. Other plugins still need .desktop files (I don't know exactly which Python they are require)