[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: [kate] /: Refactor how word completion works
From:       Sven Brauch <svenbrauch () googlemail ! com>
Date:       2013-10-29 16:37:58
Message-ID: 2402155.sttAnhMAWf () localhost ! localdomain
[Download RAW message or body]

Hi,

this is probably because I added an enum to the CodeCompletionModel class, but 
did not add it to kdelibs too, right?
What do I do, do I just add the change to kdelibs' copy of the KTextEditor 
interfaces? It's binary- and source compatible.

Greetings,
Sven

On Tuesday 29 October 2013 16:12:14 you wrote:
> Hi,
> 
> On Monday 28 October 2013 15:10:59 Sven Brauch wrote:
> > Git commit af7860df9495a6f7911b4005e974db1764fab4d2 by Sven Brauch.
> > Committed on 28/10/2013 at 14:56.
> > Pushed by brauch into branch 'master'.
> > 
> > Refactor how word completion works
> > 
> > Especially, this makes it work with the abbreviation expansion introduced
> > recently.
> > REVIEW:113476
> > 
> > M  +10   -1    ktexteditor/codecompletionmodel.h
> > M  +9    -0    part/completion/katecompletionmodel.cpp
> > M  +34   -60   part/completion/katewordcompletion.cpp
> > M  +1    -2    part/completion/katewordcompletion.h
> > M  +6    -0    tests/CMakeLists.txt
> > A  +116  -0    tests/wordcompletiontest.cpp     [License: GPL (v2/3)]
> > A  +47   -0    tests/wordcompletiontest.h     [License: GPL (v2/3)]
> > 
> > http://commits.kde.org/kate/af7860df9495a6f7911b4005e974db1764fab4d2
> 
> This commit breaks the build for me it seems:
> 
> /kde/src/4/kdebase/kate/part/completion/katecompletionmodel.cpp: In member
> function ‘bool KateCompletionModel::Item::operator<(const
> KateCompletionModel::Item&) const':
> /kde/src/4/kdebase/kate/part/completion/katecompletionmodel.cpp:1462:46:
> error: ‘UnimportantItemRole' is not a member of
> ‘KTextEditor::CodeCompletionModel'
>    const bool isBad =
> m_sourceRow.second.data(CodeCompletionModel::UnimportantItemRole).toBool();
>                                               ^
> /kde/src/4/kdebase/kate/part/completion/katecompletionmodel.cpp:1463:55:
> error: ‘UnimportantItemRole' is not a member of
> ‘KTextEditor::CodeCompletionModel'
>    const bool otherIsBad =
> rhs.m_sourceRow.second.data(CodeCompletionModel::UnimportantItemRole).toBool
> (); ^
> /kde/src/4/kdebase/kate/part/completion/katecompletionmodel.cpp:1464:17:
> error: in argument to unary !
>    if( isBad && !otherIsBad ) {
>                  ^
> /kde/src/4/kdebase/kate/part/completion/katecompletionmodel.cpp:1467:22:
> error: in argument to unary !
>    if( otherIsBad && !isBad ) {
>                       ^
> make[2]: ***
> [part/CMakeFiles/katepartinterfaces.dir/completion/katecompletionmodel.o]
> Error 1
> 
> 
> Christophe

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread]