[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113440: katepart: Add "Smart Tabs" radio button to KateIndentConfigTab
From: "Alex Turbov" <i.zaufi () gmail ! com>
Date: 2013-10-28 16:22:46
Message-ID: 20131028162246.20446.65819 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113440/#review42541
-----------------------------------------------------------
part/dialogs/indentationconfigwidget.ui
<http://git.reviewboard.kde.org/r/113440/#comment30865>
You'd better to remove this property element completely... it doesn't needed \
actually
- Alex Turbov
On Oct. 25, 2013, 10:22 p.m., Roman Lapin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113440/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 10:22 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> This patch adds simple "Smart Tabs" function to Kate.
>
> If radio button "Smart Tabulators" is checked on Indentation Config Tab, Kate \
> inserts tabs for indentation, but fine alignment to a necessary column is done \
> only via spaces without replacing them with tabs. It helps to preserve alignment \
> (e.g. of comments), when Tab width is changed.
>
> Diffs
> -----
>
> part/dialogs/indentationconfigwidget.ui 6d1fc08
> part/dialogs/katedialogs.cpp 1bfefde
> part/document/katedocument.cpp 42b540d
> part/utils/kateconfig.h be3441d
> part/utils/kateconfig.cpp e5d8b66
>
> Diff: http://git.reviewboard.kde.org/r/113440/diff/
>
>
> Testing
> -------
>
> Kate builds.
> Changing and applying of variations rbIndent* works fine.
> Tested with several values of Tab width and Indentation width.
> PS. This is my first patch, but seems it's work in way what I want (I hope).
>
>
> Thanks,
>
> Roman Lapin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113440/">http://git.reviewboard.kde.org/r/113440/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113440/diff/1/?file=205905#file205905line10" \
style="color: black; font-weight: bold; text-decoration: \
underline;">part/dialogs/indentationconfigwidget.ui</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <height>39<span \
class="hl">0</span></height></pre></td> <th bgcolor="#e9eaa8" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <height>39<span \
class="hl">3</span></height></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You'd \
better to remove this property element completely... it doesn't needed \
actually</pre> </div>
<br />
<p>- Alex Turbov</p>
<br />
<p>On October 25th, 2013, 10:22 p.m. UTC, Roman Lapin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Roman Lapin.</div>
<p style="color: grey;"><i>Updated Oct. 25, 2013, 10:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds simple "Smart Tabs" function to Kate.
If radio button "Smart Tabulators" is checked on Indentation Config Tab, \
Kate inserts tabs for indentation, but fine alignment to a necessary column is done \
only via spaces without replacing them with tabs. It helps to preserve alignment \
(e.g. of comments), when Tab width is changed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kate builds. Changing and applying of variations rbIndent* works fine.
Tested with several values of Tab width and Indentation width.
PS. This is my first patch, but seems it's work in way what I want (I hope).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>part/dialogs/indentationconfigwidget.ui <span style="color: \
grey">(6d1fc08)</span></li>
<li>part/dialogs/katedialogs.cpp <span style="color: grey">(1bfefde)</span></li>
<li>part/document/katedocument.cpp <span style="color: grey">(42b540d)</span></li>
<li>part/utils/kateconfig.h <span style="color: grey">(be3441d)</span></li>
<li>part/utils/kateconfig.cpp <span style="color: grey">(e5d8b66)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113440/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic