[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 113403: Automatically loading git repostiories as projects
From: "Dominik Haumann" <dhaumann () kde ! org>
Date: 2013-10-23 20:14:10
Message-ID: 20131023201410.29920.53956 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113403/#review42249
-----------------------------------------------------------
I've tested this patch and it works. Can you make the code a bit more generic to \
support also .svn for subversion and .hg for mercurial?
It does not create a .kateproject file, though.
A file .kateproject.d/notes.txt is still created. Imo this should be changed, so only \
create this file if it has contents. But this is not really an issue of this patch.
Whether this is good or bad is up for discussion.
Christoph, I'll leave it up to you to give a "ship it" ;)
- Dominik Haumann
On Oct. 23, 2013, 3:15 p.m., Rafał Rzepecki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113403/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2013, 3:15 p.m.)
>
>
> Review request for Kate and Dominik Haumann.
>
>
> Bugs: 326415
> http://bugs.kde.org/show_bug.cgi?id=326415
>
>
> Repository: kate
>
>
> Description
> -------
>
> Kate project plugin is very useful; so much so that I've found myself creating \
> minimal "{name: foo; files: [{git: 1}]}" .kateproject files again and again. I \
> believe this is a common use case - only use the repo scanning capability without \
> other features of projects.
> To that end, the project plugin could, in absence of a .kateproject file and \
> presence of a git repository, simply load the repo as the project. The attached \
> patch implements this feature.
>
> Diffs
> -----
>
> addons/kate/project/kateproject.h 3aaed67
> addons/kate/project/kateproject.cpp f5557c3
> addons/kate/project/kateprojectplugin.h 74ef10b
> addons/kate/project/kateprojectplugin.cpp a7f71e6
>
> Diff: http://git.reviewboard.kde.org/r/113403/diff/
>
>
> Testing
> -------
>
> I've been using it since I wrote it, seems to work well.
>
>
> Thanks,
>
> Rafał Rzepecki
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113403/">http://git.reviewboard.kde.org/r/113403/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've tested this \
patch and it works. Can you make the code a bit more generic to support also .svn for \
subversion and .hg for mercurial?
It does not create a .kateproject file, though.
A file .kateproject.d/notes.txt is still created. Imo this should be changed, so only \
create this file if it has contents. But this is not really an issue of this patch.
Whether this is good or bad is up for discussion.
Christoph, I'll leave it up to you to give a "ship it" ;)</pre>
<br />
<p>- Dominik Haumann</p>
<br />
<p>On October 23rd, 2013, 3:15 p.m. UTC, Rafał Rzepecki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Dominik Haumann.</div>
<div>By Rafał Rzepecki.</div>
<p style="color: grey;"><i>Updated Oct. 23, 2013, 3:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=326415">326415</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Kate project plugin is very useful; so much so that I've found \
myself creating minimal "{name: foo; files: [{git: 1}]}" .kateproject files \
again and again. I believe this is a common use case - only use the repo scanning \
capability without other features of projects.
To that end, the project plugin could, in absence of a .kateproject file and presence \
of a git repository, simply load the repo as the project. The attached patch \
implements this feature.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I've been using it since I wrote it, seems to work well.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/project/kateproject.h <span style="color: \
grey">(3aaed67)</span></li>
<li>addons/kate/project/kateproject.cpp <span style="color: \
grey">(f5557c3)</span></li>
<li>addons/kate/project/kateprojectplugin.h <span style="color: \
grey">(74ef10b)</span></li>
<li>addons/kate/project/kateprojectplugin.cpp <span style="color: \
grey">(a7f71e6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113403/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic