[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 112763: Search plugin: use current word if nothing is selected
From: "Alexander Neundorf" <neundorf () kde ! org>
Date: 2013-09-17 19:24:46
Message-ID: 20130917192446.18194.73369 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112763/
-----------------------------------------------------------
(Updated Sept. 17, 2013, 7:24 p.m.)
Status
------
This change has been marked as submitted.
Review request for Kate and Kåre Särs.
Description
-------
With this patch, when starting a new search, and no text is selected, the word below \
the cursor is used as initial search pattern. The code for getWordFromDocument() is \
taken mostly from KateDocument::word(), since KTextEditor::Document doesn't have a \
word() function. IMO this makes searching even quicker.
Diffs
-----
addons/kate/search/plugin_search.h 0c56a47
addons/kate/search/plugin_search.cpp 441cb5d
Diff: http://git.reviewboard.kde.org/r/112763/diff/
Testing
-------
Thanks,
Alexander Neundorf
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112763/">http://git.reviewboard.kde.org/r/112763/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Kåre Särs.</div>
<div>By Alexander Neundorf.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2013, 7:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">With this patch, when starting a new search, and no text is selected, \
the word below the cursor is used as initial search pattern. The code for \
getWordFromDocument() is taken mostly from KateDocument::word(), since \
KTextEditor::Document doesn't have a word() function. IMO this makes searching \
even quicker.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/kate/search/plugin_search.h <span style="color: \
grey">(0c56a47)</span></li>
<li>addons/kate/search/plugin_search.cpp <span style="color: \
grey">(441cb5d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112763/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic