[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: [kate] part/utils: guard some options against setting it twice
From: Kevin Funk <krf () gmx ! de>
Date: 2013-06-28 17:42:35
Message-ID: 6986149.vc8M17FHsB () kerberos
[Download RAW message or body]
On Thursday, 27. June 2013 10:30:13 Dominik Haumann wrote:
> Git commit 256f7654bd7a1dd20c60558307511b4be1c090bd by Dominik Haumann.
> Committed on 27/06/2013 at 10:30.
> Pushed by dhaumann into branch 'master'.
>
> guard some options against setting it twice
>
> Setting an option that already is the correct value
> should not emit configChanged(). So all setters should
> have the form:
> if (!m_optionSet || m_option != option) {
> configStart();
> m_optionSet = true;
> m_option = option;
> configEnd();
> }
> This should be done for all setters in KateConfig. Then,
> potentially lots of unnecessary config-changed signals could be
> suppressed. Any volunteers?
>
> (snip)
Hey,
I've wondered about kateconfig.cpp the first time I saw it...
Why don't you simply use KConfigXT here? Most, if not all of the code inside
kateconfig.cpp could be auto-generated. Am I missing something?
Is KConfigXT *not* used because of the distinction between global and non-
global properties?
[1] https://techbase.kde.org/Development/Tutorials/Using_KConfig_XT
--
Kevin Funk
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic