'Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwrite-devel
Subject:    Re: Review Request 111000: add KTextEditor::MessageInterface for KDE SC 4.11
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-06-14 14:41:01
Message-ID: 20130614144101.4965.88421 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111000/
-----------------------------------------------------------

(Updated June 14, 2013, 2:41 p.m.)

Review request for Kate, kdelibs, Release Team, and Christoph Cullmann.

Changes
-------

Let's add the release team and not me then :-)

Description
-------

This patch adds the KTextEditor::MessageInterface to the KTextEditor interfaces in \
kdelibs 4.11.

This interface exists in Kate since KDE 4.10, and is already used internally to show \
messages when needed (e.g. search & replace, or swap file recover bar). By adding \
this interface to kdelibs, applications like KDevelop, Kile, etc... can use this \
interface to show passive interactive notifications in a KTextEditor::View.

With this commit, we also want to get feedback by potential users of this interface, \
so we can improve/tweak it again for KDE 5 (or whatever it will be called :) ).

Diffs
-----

  interfaces/ktexteditor/messageinterface.cpp PRE-CREATION 
  interfaces/ktexteditor/messageinterface.h PRE-CREATION 
  interfaces/ktexteditor/CMakeLists.txt 9813734 
  includes/KTextEditor/MessageInterface PRE-CREATION 
  includes/KTextEditor/Message PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111000/diff/

Testing
-------

Given the interface is in Kate since KDE 4.10, the interface is quite mature.

Thanks,

Dominik Haumann

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/111000/">http://git.reviewboard.kde.org/r/111000/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Kate, kdelibs, Release Team, and Christoph Cullmann.</div>
<div>By Dominik Haumann.</div>

<p style="color: grey;"><i>Updated June 14, 2013, 2:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let&#39;s add the release team and not me then :-)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds the KTextEditor::MessageInterface to the KTextEditor \
interfaces in kdelibs 4.11.

This interface exists in Kate since KDE 4.10, and is already used internally to show \
messages when needed (e.g. search &amp; replace, or swap file recover bar). By adding \
this interface to kdelibs, applications like KDevelop, Kile, etc... can use this \
interface to show passive interactive notifications in a KTextEditor::View.

With this commit, we also want to get feedback by potential users of this interface, \
so we can improve/tweak it again for KDE 5 (or whatever it will be called :) ).</pre> \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Given the interface is in Kate since KDE 4.10, the interface is quite \
mature.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>interfaces/ktexteditor/messageinterface.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>interfaces/ktexteditor/messageinterface.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>interfaces/ktexteditor/CMakeLists.txt <span style="color: \
grey">(9813734)</span></li>

 <li>includes/KTextEditor/MessageInterface <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>includes/KTextEditor/Message <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/111000/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel

[prev in list] [next in list] [prev in thread] [next in thread] 